chore: Decouple API from tRPC handlers #11947
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
1 Ignored Deployment
|
|
Thank you for following the naming conventions! 🙏 Feel free to join our discord and post your PR link to collect XP and win prizes! |
emrysal
commented
Oct 17, 2023
| try { | ||
| const input = getScheduleSchema.parse(req.query); |
There was a problem hiding this comment.
Use getSchedule parser to maintain consistency between before/after.
emrysal
commented
Oct 17, 2023
| // eslint-disable-next-line @typescript-eslint/no-explicit-any | ||
| return await caller.getSchedule(req.query as any /* Let tRPC handle this */); | ||
| } catch (cause) { | ||
| if (cause instanceof TRPCError) { |
There was a problem hiding this comment.
getAvailableSlots is heavily trpc-coupled, so this will continue to work as TRPCError is just a normal error.
📦 Next.js Bundle Analysis for @calcom/webThis analysis was generated by the Next.js Bundle Analysis action. 🤖 This PR introduced no changes to the JavaScript bundle! 🙌 |
Current Playwright Test Results Summary✅ 162 Passing - Run may still be in progress, this comment will be updated as current testing workflow or job completes... (Last updated on 10/17/2023 02:25:49pm UTC) Run DetailsRunning Workflow PR Update on Github Actions Commit: b07ab5d Started: 10/17/2023 02:23:08pm UTC
|
| Test Case | Last 7 days Failures | Last 7 days Flakes |
|---|---|---|
|
Booking with Seats Multiple Attendees can book a seated event time slot
Retry 1 • Initial Attempt |
0.66% (2)2 / 301 runsfailed over last 7 days |
0.66% (2)2 / 301 runsflaked over last 7 days |
📄 apps/web/playwright/auth/delete-account.e2e.ts • 1 Flake
Test Case Results
| Test Case | Last 7 days Failures | Last 7 days Flakes |
|---|---|---|
|
Can delete user account
Retry 1 • Initial Attempt |
0.94% (3)3 / 320 runsfailed over last 7 days |
11.88% (38)38 / 320 runsflaked over last 7 days |
📄 packages/embeds/embed-core/playwright/tests/action-based.e2e.ts • 2 Flakes
Top 1 Common Error Messages
|
|
2 Test Cases Affected |
Test Case Results
| Test Case | Last 7 days Failures | Last 7 days Flakes |
|---|---|---|
|
Popup Tests should be able to reschedule
Retry 2 • Retry 1 • Initial Attempt |
8.78% (28)28 / 319 runsfailed over last 7 days |
89.66% (286)286 / 319 runsflaked over last 7 days |
|
Popup Tests Floating Button Popup Pro User - Configured in App with default setting of system theme should open embed iframe according to system theme when no theme is configured through Embed API
Retry 1 • Initial Attempt |
3.44% (11)11 / 320 runsfailed over last 7 days |
43.44% (139)139 / 320 runsflaked over last 7 days |
keithwillcode
approved these changes
Oct 17, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Starts decoupling the API from tRPC without touching the underlying logic.