feat: use-primary-by-default-overlay #11935
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
1 Ignored Deployment
|
|
Current dependencies on/for this PR: This comment was auto-generated by Graphite. |
|
Thank you for following the naming conventions! 🙏 Feel free to join our discord and post your PR link to collect XP and win prizes! |
📦 Next.js Bundle Analysis for @calcom/webThis analysis was generated by the Next.js Bundle Analysis action. 🤖 This PR introduced no changes to the JavaScript bundle! 🙌 |
Current Playwright Test Results Summary✅ 162 Passing - Run may still be in progress, this comment will be updated as current testing workflow or job completes... (Last updated on 10/19/2023 08:37:45am UTC) Run DetailsRunning Workflow PR Update on Github Actions Commit: f346a86 Started: 10/19/2023 08:35:36am UTC
|
| Test Case | Last 7 days Failures | Last 7 days Flakes |
|---|---|---|
|
Event Types tests user Different Locations Tests can add Attendee Phone Number location and book with it
Retry 1 • Initial Attempt |
2.43% (7)7 / 288 runsfailed over last 7 days |
2.08% (6)6 / 288 runsflaked over last 7 days |
📄 apps/web/playwright/webhook.e2e.ts • 1 Flake
Test Case Results
| Test Case | Last 7 days Failures | Last 7 days Flakes |
|---|---|---|
|
FORM_SUBMITTED on submitting team form, triggers team webhook
Retry 1 • Initial Attempt |
1.07% (3)3 / 281 runsfailed over last 7 days |
8.90% (25)25 / 281 runsflaked over last 7 days |
📄 apps/web/playwright/profile.e2e.ts • 1 Flake
Test Case Results
| Test Case | Last 7 days Failures | Last 7 days Flakes |
|---|---|---|
|
Teams Profile page is loaded for users in Organization
Retry 1 • Initial Attempt |
0.71% (2)2 / 281 runsfailed over last 7 days |
29.89% (84)84 / 281 runsflaked over last 7 days |
📄 packages/embeds/embed-core/playwright/tests/action-based.e2e.ts • 2 Flakes
Top 1 Common Error Messages
|
|
2 Test Cases Affected |
Test Case Results
| Test Case | Last 7 days Failures | Last 7 days Flakes |
|---|---|---|
|
Popup Tests should open embed iframe on click - Configured with light theme
Retry 1 • Initial Attempt |
3.41% (10)10 / 293 runsfailed over last 7 days |
36.18% (106)106 / 293 runsflaked over last 7 days |
|
Popup Tests should be able to reschedule
Retry 2 • Retry 1 • Initial Attempt |
8.22% (24)24 / 292 runsfailed over last 7 days |
90.07% (263)263 / 292 runsflaked over last 7 days |
sean-brydon
changed the title
sean-brydon
commented
Oct 17, 2023
Comment on lines
+61
to
+73
| if (data?.connectedCalendars && set.size === 0 && !initalised) { | ||
| data?.connectedCalendars.forEach((item) => { | ||
| item.calendars?.forEach((cal) => { | ||
| const id = { credentialId: item.credentialId, externalId: cal.externalId }; | ||
| if (cal.primary) { | ||
| toggleValue(id); | ||
| } | ||
| }); | ||
| }); | ||
| setInitalised(true); | ||
| } | ||
| // eslint-disable-next-line react-hooks/exhaustive-deps | ||
| }, [data, hasItem, set, initalised]); |
There was a problem hiding this comment.
We have to use initialised here to ensure this only runs ONCE after the primary has been selected - allowing users to deselect the calendar if they wish
sean-brydon
force-pushed
the
10-17-feat/use-primary-by-default-overlay
branch
from
69a6b04 to
2f4b6f6
Compare
github-actions
bot
added
the
🚨 merge conflict
…y-by-default-overlay
github-actions
bot
removed
the
🚨 merge conflict
Udit-takkar
approved these changes
Oct 19, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Select primary calendar item by default in overlay calendar
Loom: https://www.loom.com/share/dc943ff5c1a64fd5a40acf96bec7e1a2