Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: Adds missing bookingId to Cancel Webhook payload #11906

Merged
merged 2 commits into from
Oct 17, 2023
Merged

feat: Adds missing bookingId to Cancel Webhook payload #11906

merged 2 commits into from
Oct 17, 2023

Conversation

manpoffc
Copy link
Contributor

What does this PR do?

This PR adds bookingId reference to the cancel webhook payload.

Fixes #11849

https://www.loom.com/share/fbeb6c3a5016422bba8dd6809396d88e?sid=4c9cb1ad-f1b7-4323-8f57-92a8769315ec

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • Chore (refactoring code, technical debt, workflow improvements)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

How should this be tested?

  • Create a webhook with triggers for booking created, booking rescheduled, booking cancelled.
  • Create a booking and cancel it.
  • The payload for the cancelled webhook will contain the bookingId.

Mandatory Tasks

  • Make sure you have self-reviewed the code. A decent size PR without self-review might be rejected.

@vercel
Copy link

vercel bot commented Oct 15, 2023 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
ui ✅ Ready (Inspect) Visit Preview 💬 Add feedback Oct 17, 2023 8:54am

@vercel
Copy link

vercel bot commented Oct 15, 2023

@manpoffc is attempting to deploy a commit to the cal Team on Vercel.

A member of the Team first needs to authorize it.

@github-actions
Copy link
Contributor

github-actions bot commented Oct 15, 2023 •
edited
Loading

Thank you for following the naming conventions! 🙏 Feel free to join our discord and post your PR link to collect XP and win prizes!

@github-actions github-actions bot added Medium priority Created by Linear-GitHub Sync webhooks area: webhooks, callback, webhook payload ⚡ Quick Wins A collection of quick wins/quick fixes that are less than 30 minutes of work ✨ feature New feature or request labels Oct 15, 2023
@manpoffc manpoffc changed the title Add bookingId to Cancel Webhook payload Fix: Adds missing bookingId to Cancel Webhook payload Oct 15, 2023
@manpoffc manpoffc changed the title Fix: Adds missing bookingId to Cancel Webhook payload fix: Adds missing bookingId to Cancel Webhook payload Oct 15, 2023
@github-actions
Copy link
Contributor

github-actions bot commented Oct 15, 2023 •
edited
Loading

📦 Next.js Bundle Analysis for @calcom/web

This analysis was generated by the Next.js Bundle Analysis action. 🤖

This PR introduced no changes to the JavaScript bundle! 🙌

@manpoffc manpoffc changed the title fix: Adds missing bookingId to Cancel Webhook payload feat: Adds missing bookingId to Cancel Webhook payload Oct 15, 2023
@alishaz-polymath
Copy link
Member

Thank you @manpoffc for the PR. I'll review this today 🙏

CarinaWolli
CarinaWolli approved these changes Oct 17, 2023
View reviewed changes
Copy link
Member

@CarinaWolli CarinaWolli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! Thank you 🙏

@CarinaWolli CarinaWolli enabled auto-merge (squash) October 17, 2023 08:50
@CarinaWolli CarinaWolli merged commit 91ac952 into calcom:main Oct 17, 2023
parteekcoder added a commit to parteekcoder/cal.com that referenced this pull request Oct 17, 2023
@parteekcoder
Revert "feat: Adds missing bookingId to Cancel Webhook payload (calco…
cf313b6 
…m#11906)"

This reverts commit 91ac952.
@alishaz-polymath alishaz-polymath mentioned this pull request Oct 27, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@CarinaWolli CarinaWolli CarinaWolli approved these changes

Assignees
No one assigned
Labels
✨ feature New feature or request Medium priority Created by Linear-GitHub Sync ⚡ Quick Wins A collection of quick wins/quick fixes that are less than 30 minutes of work webhooks area: webhooks, callback, webhook payload
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add bookingId to Cancel Webhook payload
3 participants
@manpoffc @alishaz-polymath @CarinaWolli