feat: Show link location in /bookings #11863

kremedev · 2023-10-12T16:18:56Z

What does this PR do?

Fixes #11730

/claim #11730

fin.mov

Type of change

New feature (non-breaking change which adds functionality)

Mandatory Tasks

Make sure you have self-reviewed the code. A decent size PR without self-review might be rejected.

vercel · 2023-10-12T16:19:03Z

@kremedev is attempting to deploy a commit to the cal Team on Vercel.

A member of the Team first needs to authorize it.

vercel · 2023-10-12T16:19:09Z

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name	Status	Preview	Comments	Updated (UTC)
ui	✅ Ready (Inspect)	Visit Preview	💬 Add feedback	Oct 13, 2023 7:34pm

github-actions · 2023-10-12T16:19:13Z

Thank you for following the naming conventions! 🙏 Feel free to join our discord and post your PR link to collect XP and win prizes!

github-actions · 2023-10-12T16:26:01Z

📦 Next.js Bundle Analysis for @calcom/web

This analysis was generated by the Next.js Bundle Analysis action. 🤖

⚠️ Global Bundle Size Increased

Page	Size (compressed)
`global`	`177.05 KB` (🟡 +21.12 KB)

Details

The global bundle is the javascript bundle that loads alongside every page. It is in its own category because its impact is much higher - an increase to its size means that every page on your website loads slower, and a decrease means every page loads faster.

Any third party scripts you have added directly to your app using the <script> tag are not accounted for in this analysis

If you want further insight into what is behind the changes, give @next/bundle-analyzer a try!

Nine Pages Changed Size

The following pages changed size from the code in this PR compared to its base branch:

Page	Size (compressed)	First Load	% of Budget (`350 KB`)
`/[user]/[type]`	`234.99 KB`	412.04 KB	117.73% (🟢 -0.19%)
`/[user]/[type]/embed`	`235.02 KB`	412.07 KB	117.73% (🟢 -0.18%)
`/apps/[slug]/[...pages]`	`549.03 KB`	726.09 KB	207.45% (🟢 -0.18%)
`/d/[link]/[slug]`	`234.98 KB`	412.04 KB	117.72% (🟢 -0.18%)
`/org/[orgSlug]/[user]/[type]`	`235.15 KB`	412.21 KB	117.77% (🟢 -0.18%)
`/org/[orgSlug]/[user]/[type]/embed`	`235.18 KB`	412.23 KB	117.78% (🟢 -0.18%)
`/org/[orgSlug]/team/[slug]/[type]`	`235.01 KB`	412.07 KB	117.73% (🟢 -0.18%)
`/team/[slug]/[type]`	`234.98 KB`	412.03 KB	117.72% (🟢 -0.18%)
`/team/[slug]/[type]/embed`	`235.01 KB`	412.06 KB	117.73% (🟢 -0.18%)

Details

Only the gzipped size is provided here based on an expert tip.

First Load is the size of the global bundle plus the bundle for the individual page. If a user were to show up to your website and land on a given page, the first load size represents the amount of javascript that user would need to download. If next/link is used, subsequent page loads would only need to download that page's bundle (the number in the "Size" column), since the global bundle has already been downloaded.

Any third party scripts you have added directly to your app using the <script> tag are not accounted for in this analysis

The "Budget %" column shows what percentage of your performance budget the First Load total takes up. For example, if your budget was 100kb, and a given page's first load size was 10kb, it would be 10% of your budget. You can also see how much this has increased or decreased compared to the base branch of your PR. If this percentage has increased by 20% or more, there will be a red status indicator applied, indicating that special attention should be given to this. If you see "+/- <0.01%" it means that there was a change in bundle size, but it is a trivial enough amount that it can be ignored.

PeerRich

we should not hard code logos and names, instead use whatever conference location was used

kremedev · 2023-10-13T16:30:25Z

I tried using location link inside booking prop to get app logo and name but some apps like Google and Zoom use this type.

type DynamicLinkBasedEventLocation = {
  linkType: "dynamic";
  urlRegExp?: null;
  organizerInputType?: null;
  organizerInputPlaceholder?: null;
} & CommonProperties;

Should I change this type and add urlRegExp to them?

Siddharth-2382 · 2023-10-13T17:33:41Z

Umm I tried this code and I don't think booking.location is giving you the meeting link. It just gives value like integrations:zoom or integrations:google:meet. Can you share a recording? I'm bit lost here.

kremedev · 2023-10-13T17:41:26Z

I updated the recording

Siddharth-2382 · 2023-10-13T17:43:24Z

I updated the recording

When I'm clicking on the link it takes to /integrations:google%20meet?

Did you tried going through the link?

kremedev · 2023-10-13T18:05:56Z

It shouldn't work at cal, daily, huddle, jets, and tandem since I haven't set them up yet.

I don't know how you get integrations:google:meet from booking.location. Is this how you created it?

Siddharth-2382 · 2023-10-13T18:57:43Z

It shouldn't work at cal, daily, huddle, jets, and tandem since I haven't set them up yet.

I don't know how you get integrations:google:meet from booking.location. Is this how you created it?

No I simply created an event with location set as google meet. Can you show by going to the google meet link that you're having? Like a screen recording?

kremedev · 2023-10-13T19:03:35Z

It shouldn't work at cal, daily, huddle, jets, and tandem since I haven't set them up yet.
I don't know how you get integrations:google:meet from booking.location. Is this how you created it?

No I simply created an event with location set as google meet. Can you show by going to the google meet link that you're having? Like a screen recording?

google.mov

kremedev · 2023-10-13T19:35:58Z

apps/web/components/booking/BookingListItem.tsx

+          </div>
+        );
+      }
+      const url = booking.references[0].meetingUrl;


Is this the correct way to get urls from integrations @PeerRich ?

i believe so. asking @hariombalhara to review

#11866 this looks better approach

I didn't know you wanted Join Meeting link to go booking page

addressed

PeerRich · 2023-10-17T09:53:29Z

#11866 going with this one

Update BookingListItem.tsx

245e035

algora-pbc bot added the 🙋 Bounty claim label Oct 12, 2023

algora-pbc bot mentioned this pull request Oct 12, 2023

[CAL-2590] Show link location in /bookings #11730

Closed

kremedev changed the title ~~Update BookingListItem.tsx~~ feat: Show link location in /bookings Oct 12, 2023

vercel bot deployed to Preview – ui October 12, 2023 16:22 View deployment

only links

a73bc5d

vercel bot deployed to Preview – ui October 12, 2023 16:32 View deployment

better

e47145b

vercel bot deployed to Preview – ui October 12, 2023 17:24 View deployment

zoom logo

0319087

vercel bot deployed to Preview – ui October 12, 2023 17:40 View deployment

e2e fix

44f7f89

vercel bot deployed to Preview – ui October 12, 2023 18:03 View deployment

duplicate logos

5325374

vercel bot deployed to Preview – ui October 12, 2023 18:18 View deployment

Merge branch 'main' into link

572618a

vercel bot deployed to Preview – ui October 12, 2023 20:38 View deployment

Merge branch 'main' into link

c2f141b

vercel bot deployed to Preview – ui October 13, 2023 07:19 View deployment

PeerRich previously requested changes Oct 13, 2023

View reviewed changes

location with urlRegExp works

04d1fed

vercel bot deployed to Preview – ui October 13, 2023 16:16 View deployment

better approach i guess

4a30e3e

vercel bot deployed to Preview – ui October 13, 2023 17:32 View deployment

im dumb

1d99862

vercel bot deployed to Preview – ui October 13, 2023 17:52 View deployment

meetingLink update

66dbbeb

vercel bot deployed to Preview – ui October 13, 2023 19:34 View deployment

kremedev commented Oct 13, 2023

View reviewed changes

PeerRich requested a review from hariombalhara October 17, 2023 09:52

PeerRich closed this Oct 17, 2023

kremedev deleted the link branch October 21, 2023 13:16

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

feat: Show link location in /bookings #11863

feat: Show link location in /bookings #11863

kremedev commented Oct 12, 2023 •

edited

Loading

vercel bot commented Oct 12, 2023

vercel bot commented Oct 12, 2023 •

edited

Loading

github-actions bot commented Oct 12, 2023 •

edited

Loading

github-actions bot commented Oct 12, 2023 •

edited

Loading

PeerRich left a comment

kremedev commented Oct 13, 2023 •

edited

Loading

Siddharth-2382 commented Oct 13, 2023

kremedev commented Oct 13, 2023

Siddharth-2382 commented Oct 13, 2023 •

edited

Loading

kremedev commented Oct 13, 2023

Siddharth-2382 commented Oct 13, 2023 •

edited

Loading

kremedev commented Oct 13, 2023

kremedev Oct 13, 2023

PeerRich Oct 17, 2023

PeerRich Oct 17, 2023

kremedev Oct 17, 2023

PeerRich commented Oct 17, 2023

feat: Show link location in /bookings #11863

feat: Show link location in /bookings #11863

Conversation

kremedev commented Oct 12, 2023 • edited Loading

What does this PR do?

Type of change

Mandatory Tasks

vercel bot commented Oct 12, 2023

vercel bot commented Oct 12, 2023 • edited Loading

github-actions bot commented Oct 12, 2023 • edited Loading

github-actions bot commented Oct 12, 2023 • edited Loading

📦 Next.js Bundle Analysis for @calcom/web

⚠️ Global Bundle Size Increased

Nine Pages Changed Size

PeerRich left a comment

Choose a reason for hiding this comment

kremedev commented Oct 13, 2023 • edited Loading

Siddharth-2382 commented Oct 13, 2023

kremedev commented Oct 13, 2023

Siddharth-2382 commented Oct 13, 2023 • edited Loading

kremedev commented Oct 13, 2023

Siddharth-2382 commented Oct 13, 2023 • edited Loading

kremedev commented Oct 13, 2023

kremedev Oct 13, 2023

Choose a reason for hiding this comment

PeerRich Oct 17, 2023

Choose a reason for hiding this comment

PeerRich Oct 17, 2023

Choose a reason for hiding this comment

kremedev Oct 17, 2023

Choose a reason for hiding this comment

PeerRich commented Oct 17, 2023

kremedev commented Oct 12, 2023 •

edited

Loading

vercel bot commented Oct 12, 2023 •

edited

Loading

github-actions bot commented Oct 12, 2023 •

edited

Loading

github-actions bot commented Oct 12, 2023 •

edited

Loading

kremedev commented Oct 13, 2023 •

edited

Loading

Siddharth-2382 commented Oct 13, 2023 •

edited

Loading

Siddharth-2382 commented Oct 13, 2023 •

edited

Loading