Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: added loading state to button #11624

Merged
merged 18 commits into from
Oct 19, 2023

Conversation

ashishsurya
Copy link
Contributor

@ashishsurya ashishsurya commented Sep 29, 2023

fix : add loading state button in logout page for a good UX

What does this PR do?

This PR adds a loading state to the button which moves the user login page.

Fixes #11113

https://www.loom.com/share/4b5b44da1aac457aa588fe826e3dbed9?sid=30bca723-beb6-4017-a05e-a4d6477e2d03

Requirement/Documentation

  • If there is a requirement document, please, share it here.
  • If there is ab UI/UX design document, please, share it here.

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • Chore (refactoring code, technical debt, workflow improvements)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

How should this be tested?

Please check the video and the code changes, that must be enough for testing.

  • Are there environment variables that should be set? No
  • What are the minimal test data to have? None
  • What is expected (happy path) to have (input and output)?
  • Any other important info that could help to test that PR

Mandatory Tasks

  • Make sure you have self-reviewed the code. A decent size PR without self-review might be rejected.

Checklist

  • I haven't added tests that prove my fix is effective or that my feature works
  • I haven't checked if new and existing unit tests pass locally with my changes

Ran the tests, there are some tests which are failed but not related the changes made by me

@vercel
Copy link

vercel bot commented Sep 29, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
ui ✅ Ready (Inspect) Visit Preview 💬 Add feedback Oct 19, 2023 1:45pm

@CLAassistant
Copy link

CLAassistant commented Sep 29, 2023

CLA assistant check
All committers have signed the CLA.

@vercel
Copy link

vercel bot commented Sep 29, 2023

@ashishsurya is attempting to deploy a commit to the cal-staging Team on Vercel.

A member of the Team first needs to authorize it.

@github-actions github-actions bot added the Low priority Created by Linear-GitHub Sync label Sep 29, 2023
@github-actions
Copy link
Contributor

github-actions bot commented Sep 29, 2023

Thank you for following the naming conventions! 🙏 Feel free to join our discord and post your PR link to collect XP and win prizes!

@github-actions github-actions bot added ui area: UI, frontend, button, form, input ✅ good first issue Good for newcomers 👩‍🔬 needs investigation labels Sep 29, 2023
@ashishsurya ashishsurya changed the title added loading state to button fix : added loading state to button Sep 29, 2023
@github-actions
Copy link
Contributor

github-actions bot commented Sep 29, 2023

📦 Next.js Bundle Analysis for @calcom/web

This analysis was generated by the Next.js Bundle Analysis action. 🤖

This PR introduced no changes to the JavaScript bundle! 🙌

@ashishsurya ashishsurya changed the title fix : added loading state to button fix: added loading state to button Sep 29, 2023
@github-actions github-actions bot added the 🚨 merge conflict This PR has a merge conflict that has to be addressed label Sep 30, 2023
@github-actions github-actions bot removed the 🚨 merge conflict This PR has a merge conflict that has to be addressed label Sep 30, 2023
@Rohitk131
Copy link

Hello,

I'd like to contribute to this project for Hacktoberfest. Could you please assign this issue to me?

I'm eager to help and will follow any guidelines provided.

@pragyamishra56
Copy link

could you please assign me it would be my first contribution.

@Udit-takkar
Copy link
Contributor

@Rohitk131 @pragyamishra56 this is a Pull request

@ashishsurya
Copy link
Contributor Author

@Udit-takkar why am I getting those errors

@Udit-takkar
Copy link
Contributor

Udit-takkar commented Oct 12, 2023

Screenshot 2023-10-12 at 1 46 53 PM

@ashishsurya the test is looking for <a> tag with href ="auth/login" on the logout page which you replace with a button.

so either 1) try to implement using <a> tag

  1. change the E2E test to look for button instead

@ashishsurya
Copy link
Contributor Author

Screenshot 2023-10-12 at 1 46 53 PM @ashishsurya the test is looking for tag with href ="auth/login" on the logout page which you replace with a button.

so either 1) try to implement using tag

  1. change the E2E test to look for button instead

OK, will look into this

auto-merge was automatically disabled October 13, 2023 04:01

Head branch was pushed to by a user without write access

@ashishsurya
Copy link
Contributor Author

@Udit-takkar all the tests ran successfully, its ready to merge.

@ashishsurya
Copy link
Contributor Author

@PeerRich enable auto merging,since all tests are running successfully

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
✅ good first issue Good for newcomers Low priority Created by Linear-GitHub Sync ui area: UI, frontend, button, form, input
Projects
None yet
Development

Successfully merging this pull request may close these issues.

There Should be a Loading icon when click on button events
6 participants