Skip to content

Fix LAN service cleanup after disconnect#958

Open
calcitem wants to merge 1 commit into
masterfrom
codex/fix-lan-vs-lan-network-battle-bugs-cplfw9
Open

Fix LAN service cleanup after disconnect#958
calcitem wants to merge 1 commit into
masterfrom
codex/fix-lan-vs-lan-network-battle-bugs-cplfw9

Conversation

@calcitem
Copy link
Copy Markdown
Owner

Summary

  • keep the LAN NetworkService reusable after disconnects by separating cleanup from full disposal
  • resolve pending protocol handshakes during teardown to avoid dangling futures
  • improve logging around disconnect-driven resets

Testing

  • ./format.sh s (fails: dart not available in container)

https://chatgpt.com/codex/tasks/task_e_68eb6e4e99288320a2c3959ef52108af

@github-actions
Copy link
Copy Markdown

@check-spelling-bot Report

🔴 Please review

See the 📂 files view, the 📜action log, or 📝 job summary for details.

Unrecognized words (27)
Ctl
CXXFLAGS
deinitialize
depthext
edt
efmr
evals
ewt
fal
fmr
gameplay
glm
Hms
imbalanced
kimi
MMdd
moonshotai
movetime
nmove
occ
sid
STEB
subtag
toremove
tru
workaround
zhiqi
These words are not needed and should be removed Blabla bmf NMove NOCOLOR SId Subtags

To accept these unrecognized words as correct and remove the previously acknowledged and now absent words, you could run the following commands

... in a clone of the git@github.com:calcitem/Sanmill.git repository
on the codex/fix-lan-vs-lan-network-battle-bugs-cplfw9 branch (ℹ️ how do I use this?):

curl -s -S -L 'https://raw.githubusercontent.com/check-spelling/check-spelling/main/apply.pl' |
perl - 'https://github.com/calcitem/Sanmill/actions/runs/18441874550/attempts/1' &&
git commit -m 'Update check-spelling metadata'

OR

To have the bot accept them for you, comment in the PR quoting the following line:
@check-spelling-bot apply updates.

Forbidden patterns 🙅 (2)

In order to address this, you could change the content to not match the forbidden patterns (comments before forbidden patterns may help explain why they're forbidden), add patterns for acceptable instances, or adjust the forbidden patterns themselves.

These forbidden patterns matched content:

s.b. into

\bin to\b

Pattern

\b[Nn]o[nt][- ]existent\b
Errors and Warnings ❌ (2)

See the 📂 files view, the 📜action log, or 📝 job summary for details.

❌ Errors and Warnings Count
❌ forbidden-pattern 2
⚠️ ignored-expect-variant 3

See ❌ Event descriptions for more information.

If the flagged items are 🤯 false positives

If items relate to a ...

  • binary file (or some other file you wouldn't want to check at all).

    Please add a file path to the excludes.txt file matching the containing file.

    File paths are Perl 5 Regular Expressions - you can test yours before committing to verify it will match your files.

    ^ refers to the file's path from the root of the repository, so ^README\.md$ would exclude README.md (on whichever branch you're using).

  • well-formed pattern.

    If you can write a pattern that would match it,
    try adding it to the patterns.txt file.

    Patterns are Perl 5 Regular Expressions - you can test yours before committing to verify it will match your lines.

    Note that patterns can't match multiline strings.

@sonarqubecloud
Copy link
Copy Markdown

sonarqubecloud Bot commented Feb 7, 2026

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant