Add Flutter clean steps to repository cleanup#1008
Conversation
Run flutter clean and drop pubspec.lock before git clean to clear potentially corrupted build artifacts. Protect Android keystore files with a trap so they are restored even if the clean step fails.
@check-spelling-bot Report🔴 Please reviewSee the 📂 files view, the 📜action log, or 📝 job summary for details.Unrecognized words (40)These words are not needed and should be removedBlabla bmf NMove NOCOLOR SId SubtagsTo accept these unrecognized words as correct and remove the previously acknowledged and now absent words, you could run the following commands... in a clone of the git@github.com:calcitem/Sanmill.git repository curl -s -S -L 'https://raw.githubusercontent.com/check-spelling/check-spelling/main/apply.pl' |
perl - 'https://github.com/calcitem/Sanmill/actions/runs/19534151129/attempts/1' &&
git commit -m 'Update check-spelling metadata'OR To have the bot accept them for you, comment in the PR quoting the following line: Forbidden patterns 🙅 (2)In order to address this, you could change the content to not match the forbidden patterns (comments before forbidden patterns may help explain why they're forbidden), add patterns for acceptable instances, or adjust the forbidden patterns themselves. These forbidden patterns matched content: s.b. intoPatternErrors and Warnings ❌ (2)See the 📂 files view, the 📜action log, or 📝 job summary for details.
See ❌ Event descriptions for more information. If the flagged items are 🤯 false positivesIf items relate to a ...
|
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| mv "${FLUTTER_APP_DIR}/android/key.jks" ../ | ||
| mv "${FLUTTER_APP_DIR}/android/key.properties" ../ |
There was a problem hiding this comment.
Keystore-less runs now abort clean script
With set -e enabled earlier in the script, the new mv commands bail out when key.jks or key.properties are missing, which is the common case for contributors without Android signing keys. Previously the moves failed silently and the clean steps still ran; now the script exits before reaching git clean or the Flutter clean branch whenever those files are absent.
Useful? React with 👍 / 👎.
Summary
Testing
Codex Task