Skip to content

Add Flutter clean steps to repository cleanup#1008

Open
calcitem wants to merge 1 commit into
masterfrom
codex/fix-flutter-build-failure-on-release
Open

Add Flutter clean steps to repository cleanup#1008
calcitem wants to merge 1 commit into
masterfrom
codex/fix-flutter-build-failure-on-release

Conversation

@calcitem
Copy link
Copy Markdown
Owner

Summary

  • add Flutter clean and pubspec.lock removal to the clean script to clear Dart build artifacts
  • guard Android keystore restoration with a trap and enable strict shell error handling

Testing

  • ./format.sh s (fails: dart: command not found in environment)

Codex Task

Run flutter clean and drop pubspec.lock before git clean to clear potentially corrupted build artifacts. Protect Android keystore files with a trap so they are restored even if the clean step fails.
@github-actions
Copy link
Copy Markdown

@check-spelling-bot Report

🔴 Please review

See the 📂 files view, the 📜action log, or 📝 job summary for details.

Unrecognized words (40)
Ctl
CXXFLAGS
deinitialize
depthext
edt
efmr
Espa
evals
ewt
fal
fmr
gameplay
ggerganov
ggml
glm
Hms
hpw
huggingface
imbalanced
kimi
mic
MMdd
moonshotai
movetime
nmove
nodiag
occ
puzzlename
Redownload
reinitialization
sid
STEB
subtag
Tagline
takeback
toremove
tru
utc
workaround
zhiqi
These words are not needed and should be removed Blabla bmf NMove NOCOLOR SId Subtags

To accept these unrecognized words as correct and remove the previously acknowledged and now absent words, you could run the following commands

... in a clone of the git@github.com:calcitem/Sanmill.git repository
on the codex/fix-flutter-build-failure-on-release branch (ℹ️ how do I use this?):

curl -s -S -L 'https://raw.githubusercontent.com/check-spelling/check-spelling/main/apply.pl' |
perl - 'https://github.com/calcitem/Sanmill/actions/runs/19534151129/attempts/1' &&
git commit -m 'Update check-spelling metadata'

OR

To have the bot accept them for you, comment in the PR quoting the following line:
@check-spelling-bot apply updates.

Forbidden patterns 🙅 (2)

In order to address this, you could change the content to not match the forbidden patterns (comments before forbidden patterns may help explain why they're forbidden), add patterns for acceptable instances, or adjust the forbidden patterns themselves.

These forbidden patterns matched content:

s.b. into

\bin to\b

Pattern

\b[Nn]o[nt][- ]existent\b
Errors and Warnings ❌ (2)

See the 📂 files view, the 📜action log, or 📝 job summary for details.

❌ Errors and Warnings Count
❌ forbidden-pattern 2
⚠️ ignored-expect-variant 3

See ❌ Event descriptions for more information.

If the flagged items are 🤯 false positives

If items relate to a ...

  • binary file (or some other file you wouldn't want to check at all).

    Please add a file path to the excludes.txt file matching the containing file.

    File paths are Perl 5 Regular Expressions - you can test yours before committing to verify it will match your files.

    ^ refers to the file's path from the root of the repository, so ^README\.md$ would exclude README.md (on whichever branch you're using).

  • well-formed pattern.

    If you can write a pattern that would match it,
    try adding it to the patterns.txt file.

    Patterns are Perl 5 Regular Expressions - you can test yours before committing to verify it will match your lines.

    Note that patterns can't match multiline strings.

Copy link
Copy Markdown

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

Comment thread clean.sh
Comment on lines +12 to +13
mv "${FLUTTER_APP_DIR}/android/key.jks" ../
mv "${FLUTTER_APP_DIR}/android/key.properties" ../
Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

P1 Badge Keystore-less runs now abort clean script

With set -e enabled earlier in the script, the new mv commands bail out when key.jks or key.properties are missing, which is the common case for contributors without Android signing keys. Previously the moves failed silently and the clean steps still ran; now the script exits before reaching git clean or the Flutter clean branch whenever those files are absent.

Useful? React with 👍 / 👎.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant