Skip to content

Fix incomplete session description#1001

Open
calcitem wants to merge 2 commits into
masterfrom
claude/fix-session-description-01H4ofC3LEJt9tzAgPnPaQcs
Open

Fix incomplete session description#1001
calcitem wants to merge 2 commits into
masterfrom
claude/fix-session-description-01H4ofC3LEJt9tzAgPnPaQcs

Conversation

@calcitem
Copy link
Copy Markdown
Owner

Recent entries were added to the middle of ARB files instead of following the template order from intl_en.arb. This commit normalizes all ARB files to match the template structure exactly:

  • Reordered all keys to match intl_en.arb
  • Moved entries that were inserted in the middle to their correct positions
  • Added missing metadata descriptions
  • Maintained 4-space indentation style

Changes:

  • 62 ARB files normalized (intl_zh.arb was already correct)
  • All files now pass order validation checks

Tool used: scripts/normalize_arb_order.py

📜 Description

💡 Motivation and Context

💚 How did you test it?

📝 Checklist

  • I reviewed submitted code
  • I added tests to verify changes
  • I updated the docs if needed
  • All tests passing
  • No breaking changes

🔮 Next steps

Recent entries were added to the middle of ARB files instead of following
the template order from intl_en.arb. This commit normalizes all ARB files
to match the template structure exactly:

- Reordered all keys to match intl_en.arb
- Moved entries that were inserted in the middle to their correct positions
- Added missing metadata descriptions
- Maintained 4-space indentation style

Changes:
- 62 ARB files normalized (intl_zh.arb was already correct)
- All files now pass order validation checks

Tool used: scripts/normalize_arb_order.py
@github-actions

This comment has been minimized.

Localized 361 new translation keys for all 63 supported languages,
including puzzle features, voice assistant settings, game variants,
and UI elements.

Translation highlights:
- High-quality native translations for: ar, de, es, fr, it, ja, ko, nl, pt, ru, sv, zh
- Proper localization of:
  * Puzzle system (パズル, Énigmes, Головоломки, etc.)
  * Voice assistant features
  * Game difficulty levels
  * Month names and UI elements
  * Game variant names (preserved as transliterations)
- RTL language support for Arabic, Hebrew, Persian, Urdu
- ICU MessageFormat placeholders preserved

Total translations added: ~22,000+ across 63 languages
Languages: af, am, ar, az, be, bg, bn, bo, bs, ca, cs, da, de, de_CH,
el, es, et, fa, fi, fr, gu, he, hi, hr, hu, hy, id, is, it, ja, ka, km,
kn, ko, lt, lv, mk, ms, my, nb, nl, pl, pt, ro, ru, si, sk, sl, sq, sr,
sv, sw, ta, te, th, tr, uk, ur, uz, vi, zh, zh_Hant, zu
@github-actions
Copy link
Copy Markdown

@check-spelling-bot Report

🔴 Please review

See the 📂 files view, the 📜action log, or 📝 job summary for details.

Unrecognized words (40)
Ctl
CXXFLAGS
deinitialize
depthext
edt
efmr
Espa
evals
ewt
fal
fmr
gameplay
ggerganov
ggml
glm
Hms
hpw
huggingface
imbalanced
kimi
mic
MMdd
moonshotai
movetime
nmove
nodiag
occ
puzzlename
Redownload
reinitialization
sid
STEB
subtag
Tagline
takeback
toremove
tru
utc
workaround
zhiqi
These words are not needed and should be removed Blabla bmf NMove NOCOLOR SId Subtags

To accept these unrecognized words as correct and remove the previously acknowledged and now absent words, you could run the following commands

... in a clone of the git@github.com:calcitem/Sanmill.git repository
on the claude/fix-session-description-01H4ofC3LEJt9tzAgPnPaQcs branch (ℹ️ how do I use this?):

curl -s -S -L 'https://raw.githubusercontent.com/check-spelling/check-spelling/main/apply.pl' |
perl - 'https://github.com/calcitem/Sanmill/actions/runs/19485783094/attempts/1' &&
git commit -m 'Update check-spelling metadata'

OR

To have the bot accept them for you, comment in the PR quoting the following line:
@check-spelling-bot apply updates.

Forbidden patterns 🙅 (2)

In order to address this, you could change the content to not match the forbidden patterns (comments before forbidden patterns may help explain why they're forbidden), add patterns for acceptable instances, or adjust the forbidden patterns themselves.

These forbidden patterns matched content:

s.b. into

\bin to\b

Pattern

\b[Nn]o[nt][- ]existent\b
Errors and Warnings ❌ (2)

See the 📂 files view, the 📜action log, or 📝 job summary for details.

❌ Errors and Warnings Count
❌ forbidden-pattern 2
⚠️ ignored-expect-variant 3

See ❌ Event descriptions for more information.

If the flagged items are 🤯 false positives

If items relate to a ...

  • binary file (or some other file you wouldn't want to check at all).

    Please add a file path to the excludes.txt file matching the containing file.

    File paths are Perl 5 Regular Expressions - you can test yours before committing to verify it will match your files.

    ^ refers to the file's path from the root of the repository, so ^README\.md$ would exclude README.md (on whichever branch you're using).

  • well-formed pattern.

    If you can write a pattern that would match it,
    try adding it to the patterns.txt file.

    Patterns are Perl 5 Regular Expressions - you can test yours before committing to verify it will match your lines.

    Note that patterns can't match multiline strings.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants