Fix for PayrollAu\Settings not parsing #766
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The PayrollAU\Settings endpoint is 1D the same as Payslip / Payitems, or at least editing it in the way I have makes it work properly. Sorry I don't know how to check if it works with \PayrollUS or \Assets or if there are other \Settings objects to look out for
This is not necessary, can just reuse the Accounting\Account model
Add helpful constants
This reverts commit fad90ef.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As title says
Also flirted with just using the existing Accounting\Accounts instead of PayrollAU\Settings\Account but I don't know the ramifications of doing that so I left it alone