mobile: Adjust all sizes for Calamares 3.3.x #29
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Element sizing in Calamares 3.3.x seems to have dramatically changed, with for example a button that was previously fine at width 500 now being huge to the point of causing the installer to overhang the screen. This reduces the size of most elements such that they fit on a mobile screen again. Fixes: calamares/calamares#2192
|
I'm going to land this because I have no way of checking this for correctness or in-correctness. That's up to the consumers (you, plus PostmarketOS) of this module. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Element sizing in Calamares 3.3.x seems to have dramatically changed, with for example a button that was previously fine at width 500 now being huge to the point of causing the installer to overhang the screen.
This reduces the size of most elements such that they fit on a mobile screen again.
Fixes: calamares/calamares#2192
Note: since taking these screenshots I've adjusted all button widths to 200 (the smaller ones were 100). I'm also still unsure whether this is an expected outcome of Calamares 3.3.x or should be considered a bug.
