mobile: change min pass length to 6 digits #24
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Require at least 6 characters instead of 8 and mention that digits can also be used. Most users set something like a 6 digit number on their lockscreen, it is even what we have by default in the postmarketOS images when you don't use the installer. So requiring 8 in the installer does not make sense. Fixes: https://gitlab.com/postmarketOS/postmarketos-ondev/-/issues/62
demmm
approved these changes
Jun 5, 2023
|
Thanks for the review! @demmm, @adriaandegroot: would it be possible to tag another release after this is merged? |
|
@ollieparanoid I do not have merge or release rights in this repo (seems I also lost review rights since yesterday...) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Require at least 6 characters instead of 8 and mention that digits can also be used. Most users set something like a 6 digit number on their lockscreen, it is even what we have by default in the postmarketOS images when you don't use the installer. So requiring 8 in the installer does not make sense.
Fixes: https://gitlab.com/postmarketOS/postmarketos-ondev/-/issues/62