Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

calabash can now touch most keyboard delete keys #289

Merged
merged 4 commits into from
Jan 14, 2014

Conversation

jmoody
Copy link
Contributor

@jmoody jmoody commented Jan 14, 2014

fixes: #256

Known Issues

device/iOS combinations marked below with '*' have known issues.

  1. iPhone 4S/Simulator iOS 6.1 without instruments cannot interact with the UIKeyboardTypeNamePhonePad keyboard.

    # i think this is not correct
    > query("view:'UIKBKeyplaneView'", 'keyplane', 'componentName')
    [
      [0] "Letters"
    ]
    > query("view:'UIKBKeyplaneView'", 'keyplane', 'name')
    [
      [0] "2564535898_iPhone-NamePhonePad-Keyboard_Letters"
    ]
    
  2. Then dial "+86898888888*"

    • fails on iPhone 4S/Simulator iOS 6 without Instruments because the '+' button is not touched (the keyplane) is not found
    • works with Instruments on devices
    • UIKeyboardTypePhonePad
    # i think this is not correct
    > query("view:'UIKBKeyplaneView'", 'keyplane', 'componentName')
    [
    >  [0] "Default"
    ]
    > query("view:'UIKBKeyplaneView'", 'keyplane', 'name')
    [
      [0] "iPhone-Portrait-PhonePad_Default"
    ]
    
  3. Then I type pi as "3.16" step will fail if the device is in a locale that uses ',' as the decimal separator. will result in a 'pending' exception.

    • i am not convinced that calabash should be detecting locales. However, the server should be able to report NSLocale information.
  4. does not fix sporadic json parse errors: calabash - intermittent uia failures - "a JSON text must at least contain two octets!" #259

  5. does not fix uia_type_string skipping or missing chars: uia_type_string fails to input the correct case or incorrectly touches the wrong character on _devices_ #269

these are all issues that are not related to this issue, so i think we should ignore them and submit this fix. my guess is that these keyboards have never worked. i have made separate issues for them.

Testing

Briar

NO_LAUNCH=1 ==> Manually Launching ==> UIA not available

  • iPhone 4S iOS 6 (1,2*)
  • iPad 1 iOS 5.1.1
  • iPhone Simulator iOS 6.1 (1*)
  • iPad Simulator iOS 6.1

NO_LAUNCH=0 ==> Launching with Instruments ==> UIA available

  • iPhone 4S iOS 6
  • iPhone 5C iOS 7.0.2 (2*)
  • iPad 4 iOS 7.0.3
  • iPhone Simulator iOS 7
  • iPad Simulator iOS 7

NO_LAUNCH=0 ==> Launching with Sim Launcher ==> UIA not available

  • iPhone Simulator iOS 6.1 (1,2*)
  • iPad Simulator iOS 6.1

Smoke Tests

  • ruby 2.0
  • ruby 1.9
  • ruby 1.8

XTC

LPSimpleExample (smoke test)

LPSimpleExample

Apple iPhone 5S (7.0.4)

  • ruby 2.0
  • ruby 1.9
  • ruby 1.8

Briar iOS Example @issue_256

briar-ios-example 1.1.5

  • ruby 2.0
    • Apple iPhone 5C (7.0.4)
    • Apple iPhone 4S (6.1.3)
    • Apple iPad 4th Gen (7.0.4)
    • Apple iPad 2 (5.1.1)

jmoody added a commit that referenced this pull request Jan 14, 2014
…board

calabash can now touch most keyboard delete keys
@jmoody jmoody merged commit 08e1c91 into calabash:0.9.x Jan 14, 2014
@jmoody jmoody deleted the 0.9.x-touch-delete-on-numeric-keyboard branch January 14, 2014 23:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant