Remove annual_database_service models and manual scrape process #3524
+0
−76
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
erikamov
requested review from
evansiroky,
vevetron,
tiffanychu90 and
hunterowens
as code owners
Replaced by external_ntd__annual_reporting and new models: - dim_annual_service_agencies - dim_annual_service_mode_time_periods - fct_annual_service_modes [#3497]
erikamov
force-pushed
the
3497-deprecate-ntd-tables
branch
from
5f864d6
to
abdedec
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
As part of deprecating old NTD tables for #3497 this PR is removing the annual_database_service models and data deprecate process that was replaced by external_ntd__annual_reporting new models:
Type of change
How has this been tested?
No references of removed tables on
cal-itprepo was found that could give a dependency error.Executed locally
create_external_tablesDAG without any error.Run scrape_ntd.py for a different product successfully.
Post-merge follow-ups
Drop the following tables from
cal-itp-data-infra.external_ntd_data_products.annual_database_servicestg_ntd__annual_database_serviceDelete folders from
calitp-ntd-data-productsbucket:* annual-database-service_raw
* annual-database-service