-
Notifications
You must be signed in to change notification settings - Fork 118
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix up Migrations for Phinx 0.13 integration. #517
Conversation
d230de4
to
f2c6bd2
Compare
I might need a bit help for the remaining errors.
Any idea why this would be happening now? |
Signed-off-by: Matthew Peveler <matt.peveler@gmail.com>
Override phinx hasConfig method
Not sure what the |
No, I updated those references, tests should now run. |
needs to rebase |
Yeah, wrong branch as well, I guess The 3.x release was bad, without those changes :/ |
@dereuromark what is the status of this PR? Anything I can do to help this along to continue on releasing phinx 0.13? |
Do we have any blockers from Migrations side? I remember there were some tests failing that we didnt know how to handle. |
I suspect there are more test failures, but the merge conflicts in this PR need to be resolved first so that the test suite runs again? Also not sure if the test failures are things that need me to look at from the phinx side, or if they're more migrations specific stuff. |
Fix up Migrations for Phinx 0.13 integration. (#517)
Together with cakephp/phinx#2033 this enables new Phinx major together with CakePHP 4.3+.
PHPStan passes, but Psalm has a few issues still it seems, even though they should be gone (I tried to clear cache, didn't help)
TODO: Also JSON part seems broken/problematic as per return type of parent.