Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix up Migrations for Phinx 0.13 integration. #517

Merged
merged 28 commits into from
Dec 7, 2022
Merged

Conversation

dereuromark
Copy link
Member

Together with cakephp/phinx#2033 this enables new Phinx major together with CakePHP 4.3+.

PHPStan passes, but Psalm has a few issues still it seems, even though they should be gone (I tried to clear cache, didn't help)

TODO: Also JSON part seems broken/problematic as per return type of parent.

@dereuromark dereuromark changed the title Fix up CS to avoid having to exlude Migrations. Fix up Migrations for Phinx 0.13 integration. Oct 15, 2021
@dereuromark
Copy link
Member Author

dereuromark commented Oct 15, 2021

I might need a bit help for the remaining errors.

1) Migrations\Test\TestCase\Command\BakeMigrationDiffCommandTest::testEmptyHistoryNoMigrations
Symfony\Component\Console\Exception\InvalidArgumentException: The "configuration" option does not exist.

/home/runner/work/migrations/migrations/vendor/symfony/console/Input/Input.php:158
/home/runner/work/migrations/migrations/vendor/robmorgan/phinx/src/Phinx/Console/Command/AbstractCommand.php:239
/home/runner/work/migrations/migrations/vendor/robmorgan/phinx/src/Phinx/Console/Command/AbstractCommand.php:281
/home/runner/work/migrations/migrations/vendor/robmorgan/phinx/src/Phinx/Console/Command/AbstractCommand.php:117
/home/runner/work/migrations/migrations/src/Command/Phinx/CommandTrait.php:66
/home/runner/work/migrations/migrations/src/Command/Phinx/MarkMigrated.php:112

Any idea why this would be happening now?

@dereuromark dereuromark mentioned this pull request Oct 18, 2021
4 tasks
dereuromark and others added 2 commits October 19, 2021 02:15
Signed-off-by: Matthew Peveler <matt.peveler@gmail.com>
Override phinx hasConfig method
@MasterOdin
Copy link
Member

MasterOdin commented Nov 1, 2021

Not sure what the 0.next-assoc branch was in phinx? Should that be recreated?

@dereuromark
Copy link
Member Author

No, I updated those references, tests should now run.

@saeideng
Copy link
Member

saeideng commented Nov 2, 2021

needs to rebase

@dereuromark
Copy link
Member Author

Yeah, wrong branch as well, I guess
It should probably to towards 3.x now.

The 3.x release was bad, without those changes :/

@MasterOdin
Copy link
Member

@dereuromark what is the status of this PR? Anything I can do to help this along to continue on releasing phinx 0.13?

@dereuromark
Copy link
Member Author

Do we have any blockers from Migrations side? I remember there were some tests failing that we didnt know how to handle.

@MasterOdin
Copy link
Member

MasterOdin commented Nov 12, 2021

I suspect there are more test failures, but the merge conflicts in this PR need to be resolved first so that the test suite runs again? Also not sure if the test failures are things that need me to look at from the phinx side, or if they're more migrations specific stuff.

@dereuromark dereuromark merged commit 07941e7 into 3.next Dec 7, 2022
@dereuromark dereuromark deleted the 3.next-phinx-0.13 branch December 7, 2022 08:58
dereuromark added a commit that referenced this pull request Dec 9, 2022
Fix up Migrations for Phinx 0.13 integration. (#517)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants