Skip to content

Add docs for HtmlHelper::importmap()#7985

Merged
markstory merged 1 commit into5.nextfrom
5.2-importmap
Jan 21, 2025
Merged

Add docs for HtmlHelper::importmap()#7985
markstory merged 1 commit into5.nextfrom
5.2-importmap

Conversation

@ADmad
Copy link
Member

@ADmad ADmad commented Jan 20, 2025

No description provided.

@ADmad ADmad added this to the 5.next milestone Jan 20, 2025
}
},
"integrity": {
"/js/jquery.js": "sha256-hash"
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I wonder if we should make this example more complete, or skip it? Having a broken example in the docs doesn't feel good, as the copy-paster is going to have an error. For this to work correctly, we need the base64_encode(sha256) of the file contents.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have updated the integrity example.

@ADmad ADmad force-pushed the 5.2-importmap branch 3 times, most recently from d3c4364 to cd61a85 Compare January 21, 2025 08:42
@markstory markstory merged commit 25c978b into 5.next Jan 21, 2025
3 checks passed
@markstory markstory deleted the 5.2-importmap branch January 21, 2025 20:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants