Skip to content

Allow disabling lenient IntlDateFormatter parsing #14522

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
May 2, 2020
Merged

Allow disabling lenient IntlDateFormatter parsing #14522

merged 2 commits into from
May 2, 2020

Conversation

@othercorey
Copy link
Member

@othercorey othercorey commented Apr 30, 2020

Closes #14519

@othercorey othercorey added this to the 4.1.0 milestone Apr 30, 2020
@othercorey
Copy link
Member Author

othercorey commented Apr 30, 2020

Maybe this should be enableLenientParsing() and disableLenientParsing() and not worry about clearing. No one is going to need that scenario and this reads easier.

ADmad
ADmad reviewed Apr 30, 2020
View reviewed changes
markstory
markstory reviewed May 1, 2020
View reviewed changes
@othercorey @markstory
Fixed lenient spelling
f745eef 
Co-authored-by: Mark Story <mark@mark-story.com>
@othercorey othercorey mentioned this pull request May 1, 2020
Merged
@ADmad ADmad linked an issue May 1, 2020 that may be closed by this pull request
Use setLenient(false) when parsing localized date(time) #14519
Closed
3 tasks
@markstory markstory merged commit 72e33e7 into 4.next May 2, 2020
@markstory markstory deleted the datefmt-lenient branch May 2, 2020 03:24
CauanCabral pushed a commit to CauanCabral/cakephp that referenced this pull request Jun 8, 2020
Allow disabling lenient IntlDateFormatter parsing
c4660b2 
Backport cakephp#14522
@CauanCabral CauanCabral mentioned this pull request Jun 8, 2020
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@markstory markstory markstory left review comments

@ADmad ADmad ADmad left review comments

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

4.1.0

Development

Successfully merging this pull request may close these issues.

Use setLenient(false) when parsing localized date(time)

4 participants

@othercorey @markstory @ADmad