Skip to content

Conversation

@ADmad
Copy link
Member

@ADmad ADmad commented Feb 21, 2024

With debug enabled the WebExceptionRenderer switches the template to pdo_error.php in case of a PDOException, so having checks for SQL query related stuff in debug mode is redundant.

Refs #970, closes #992.

@ADmad ADmad added this to the 5.x milestone Feb 21, 2024
With debug enabled the WebExceptionRenderer switches the template to pdo_error.php in case
of a PDOException, so having checks for SQL query related stuff in debug mode is redundant.

Refs #970, closes #992.
@othercorey
Copy link
Member

Looks ok to me.

@markstory markstory merged commit 2fd3ace into 5.x Feb 21, 2024
@markstory markstory deleted the error-templates branch February 21, 2024 20:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Error templates

4 participants