Skip to content

Re-enable migrations plugin #925

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
othercorey merged 1 commit into from
Dec 10, 2022
Merged

Re-enable migrations plugin #925

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions composer.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,6 +7,7 @@
"require": {
"php": ">=8.1",
"cakephp/cakephp": "5.x-dev",
"cakephp/migrations": "dev-cake5",
"cakephp/plugin-installer": "2.x-dev",
"mobiledetect/mobiledetectlib": "^3.74"
},
Expand Down
3 changes: 1 addition & 2 deletions src/Application.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -127,8 +127,7 @@ protected function bootstrapCli(): void
$this->addOptionalPlugin('Cake/Repl');
$this->addOptionalPlugin('Bake');

// TODO: Renable after Migrations plugin is upgraded for Cake 5 compatibility
// $this->addPlugin('Migrations');
$this->addPlugin('Migrations');

// Load more plugins here
}
Expand Down
3 changes: 1 addition & 2 deletions tests/TestCase/ApplicationTest.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -47,8 +47,7 @@ public function testBootstrap()

$this->assertTrue($plugins->has('Bake'), 'plugins has Bake?');
$this->assertFalse($plugins->has('DebugKit'), 'plugins has DebugKit?');
// TODO: Renable after Migrations plugin is upgraded for Cake 5 compatibility
// $this->assertTrue($plugins->has('Migrations'), 'plugins has Migrations?');
$this->assertTrue($plugins->has('Migrations'), 'plugins has Migrations?');
}

/**
Expand Down
4 changes: 2 additions & 2 deletions tests/bootstrap.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -17,6 +17,7 @@

use Cake\Core\Configure;
use Cake\Datasource\ConnectionManager;
use Migrations\TestSuite\Migrator;

/**
* Test runner bootstrap.
Expand Down Expand Up @@ -62,5 +63,4 @@
// use Cake\TestSuite\Fixture\SchemaLoader;
// (new SchemaLoader())->loadSqlFiles('./tests/schema.sql', 'test');

// TODO: Renable after Migrations plugin is upgraded for Cake 5 compatibility
// (new Migrator())->run();
(new Migrator())->run();