Skip to content

Refactor swap logic and state management - #3472

Draft
malik1004x wants to merge 124 commits into
devfrom
cw-1556-refactor-swap
Draft

Refactor swap logic and state management#3472
malik1004x wants to merge 124 commits into
devfrom
cw-1556-refactor-swap

Conversation

@malik1004x

@malik1004x malik1004x commented Aug 1, 2026

Copy link
Copy Markdown
Contributor

Issue Number (if Applicable): Fixes #

Description

Refactors most logic involved in the swapping flow:

  • The ViewModel has been migrated from Mobx to Bloc with proper event handling with minimized race conditions.
  • Provider API handling has been moved from dynamic casts to proper schema classes with code generation for JSON parsing.
  • Unit tests have been added for the flow.

Pull Request - Checklist

  • Initial Manual Tests Passed
  • Double check modified code and verify it with the feature/task requirements
  • Format code
  • Look for code duplication
  • Clear naming for variables and methods
  • Manual tests in accessibility mode (TalkBack on Android) passed

malik1004x added 30 commits July 20, 2026 14:47
@malik1004x
(wip) swap refactor
21a70d4
@malik1004x
Merge branch 'refs/heads/dev' into cw-1556-refactor-swap
dc00572
@malik1004x
adjust ui to bloc
77c7ead
@malik1004x
refactor swap providers to fit new flow - chainflip
59bb1e6
@malik1004x
wip provider refactor
02266e6
@malik1004x
provider refactor wip
19266ae
@malik1004x
provider refactor
b64f877
@malik1004x
move swapsxyz logic to swapsxyz class
2d14659
@malik1004x
fix errors
7bfc9ca
@malik1004x
remove unused providers
4cedc41
@malik1004x
update registry
dabb4ac
@malik1004x
add api fixtures
466407f
@malik1004x
add fetch exchange fixtures script
503c3b4
@malik1004x
remove broken thorchain logic
7ac4183
@malik1004x
add unit tests for serialization
8907a9e
@malik1004x
fix broken cases in serialization (per unit tests)
b869c87
@malik1004x
remove unused functions from send
64223d2
@malik1004x
ProxyWrapper() -> proxyWrapper (for unit tests)
70678ad
@malik1004x
format/autofix providers
1718451
@malik1004x
remove unused widgets
0604669
@malik1004x
remove refs to nonexistent code
7511db0
@malik1004x
fix for 3.11 sdk
720371e
@malik1004x
Building with Sound Null Safety! 💪
826cae1
@malik1004x
tiny provider fixes
f92aa06
@malik1004x
readd lookupAddressByName to proper class
5c3d8be
@malik1004x
readd these because apparently they're still used
cc9908e
@malik1004x
add unit tests for provider code
be75c3e
@malik1004x
fix provider issues uncovered by unit test
00bffa2
@malik1004x
readd providerName
b7ae3ae
@malik1004x
fix migration from hive
e7c8924
malik1004x added 30 commits July 31, 2026 21:52
@malik1004x
store provider settings
dfd43d8
@malik1004x
don't store 1 = 0 rates
9de5091
@malik1004x
small save/load fix
d3b85f3
@malik1004x
fix trade tile
17fe8af
@malik1004x
fallback to different providers on fail
684da6a
@malik1004x
change payoutAddress in TradeRequest to String
be1a63f
@malik1004x
fix exolix error message
ab7a276
@malik1004x
ln receive support
7d9c568
@malik1004x
remove unused methods
e713c86
@malik1004x
fix zero bug
ead2c24
@malik1004x
stop cards from disappearing when state is gone
ab4ec30
@malik1004x
reformat
0c643b7
@malik1004x
logs
980b432
@malik1004x
migration
36edd2a
@malik1004x
Merge branch 'dev' into cw-1556-refactor-swap
e29df0a 
# Conflicts:
#	lib/exchange/provider/changenow_exchange_provider.dart
#	lib/new-ui/pages/swap_page.dart
#	lib/new-ui/widgets/swap_page/swap_confirm_sheet.dart
#	lib/src/screens/exchange/exchange_page.dart
@malik1004x
fix old trades not showing in history
f693fc6
@malik1004x
rate timer
59c83a4
@malik1004x
fix secrets parse
ebf7946
@malik1004x
remove print
34e881b
@malik1004x
parse -> safeParse
dea56f6
@malik1004x
dispose properly
ae50ef8
@malik1004x
state emit fix since this was made before i did more than 2 states
3c181b0
@malik1004x
account check that makes sense
5bc23d5
@malik1004x
only allow proceeding if we have rates
c29aa7e
@malik1004x
disable dragging down the confirm sheet (like on send)
8def157
@malik1004x
better input validation
e3e2032
@malik1004x
Merge branch 'dev' into cw-1556-refactor-swap
7f7d696 
# Conflicts:
#	lib/new-ui/pages/swap_page.dart
#	lib/new-ui/widgets/send_page/send_confirm_bottom_widget.dart
#	lib/new-ui/widgets/swap_page/provider_options_page.dart
#	lib/new-ui/widgets/swap_page/provider_selector_page.dart
#	lib/new-ui/widgets/swap_page/swap_address_selection_modal.dart
#	lib/new-ui/widgets/swap_page/swap_confirm_sheet.dart
#	lib/new-ui/widgets/swap_page/swap_options_page.dart
#	lib/new-ui/widgets/swap_page/swap_send_external_modal.dart
@malik1004x
fix no_http_imports ci
769dd10
@malik1004x
fix select all on centralized
abcdc3e
@malik1004x
chainflip throw on status code
11b925a
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

1 participant

@malik1004x