Cw 1287 add lws support #2743
Draft
Cw 1287 add lws support #2743
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Adds the class responsible for interfacing with LWS
This commit enables us to set a node as an LWS server. It also provides a toggle checkbox on server creation when we add a Monero node (only Monero, not alternate chains)
This commit cleans up a number of areas, standardises how addresses are generated, and cleans up things such that they should use dynamic versions of the values they require
This commit adds the ability to get address transactions (with key_images for determining which have been spent) It also adds get_unspent_outs, which retrieves a list of all outputs that are candidates for not having been spent yet. To determine if an output has been spent yet, check the key image hash against Monero's blockchain's list of all key image hashes It additionally adds get_decoy_outputs, which can be used in conjunction with an unspent output in order to act as decoys to obfuscate the true spend
Legacy wallets never had a "isLWSEnabled" field, removed boolean argument
One option considered was to treat an LWS Monero wallet as a different WalletType, but instead eventually opted to treat it as a special case of a Monero wallet (to inherit the base functionality)
isLWSEnabled now iniitialises to false if not set
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue Number (if Applicable): Fixes #
Description
Please include a summary of the changes and which issue is fixed / feature is added.
Pull Request - Checklist