CW-1099-Add-Doge-coin-to-Cake-Wallet #2396
Open
+1,083
−32
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Updated the isElectrum getter to include WalletType.dogecoin, ensuring Dogecoin wallets are correctly identified as Electrum-compatible.
OmarHatem28
reviewed
Jul 26, 2025
| @@ -489,6 +494,9 @@ abstract class ElectrumWalletAddressesBase extends WalletAddresses with Store { | |||
| case WalletType.bitcoinCash: | |||
| addBitcoinCashAddressTypes(); | |||
| break; | |||
| case WalletType.dogecoin: | |||
| addBitcoinCashAddressTypes(); | |||
There was a problem hiding this comment.
Would prefer if we rename the function to addP2PKHAddressTypes then
| @@ -44,6 +44,7 @@ abstract class AdvancedPrivacySettingsViewModelBase with Store { | |||
|
|
|||
| case WalletType.bitcoin: | |||
| case WalletType.litecoin: | |||
| case WalletType.dogecoin: | |||
There was a problem hiding this comment.
should always be true like bitcoincash as this won't have electrum seed type
| @@ -252,6 +253,8 @@ abstract class WalletKeysViewModelBase with Store { | |||
| return 'zano-wallet'; | |||
| case WalletType.decred: | |||
| return 'decred-wallet'; | |||
| case WalletType.dogecoin: | |||
| return 'dogecoin-wallet'; | |||
There was a problem hiding this comment.
should be added in info.plistBase
scripts/ios/app_config.sh
Outdated
There was a problem hiding this comment.
what about other platforms? macos, windows and linux
There was a problem hiding this comment.
should be in gitignore
| required Box<UnspentCoinsInfo> unspentCoinsInfo, | ||
| required Uint8List seedBytes, | ||
| required EncryptionFileUtils encryptionFileUtils, | ||
| String derivationPath = "m/44'/3'/0'", |
There was a problem hiding this comment.
unused
Suggested change
| String derivationPath = "m/44'/3'/0'", |
Comment on lines
+139
to
+159
| initialAddresses: snp?.addresses.map((addr) { | ||
| try { | ||
| return BitcoinAddressRecord( | ||
| addr.address, | ||
| index: addr.index, | ||
| isHidden: addr.isHidden, | ||
| name: addr.name, | ||
| type: P2pkhAddressType.p2pkh, | ||
| network: DogecoinNetwork.mainnet, | ||
| ); | ||
| } catch (_) { | ||
| return BitcoinAddressRecord( | ||
| addr.address, | ||
| index: addr.index, | ||
| isHidden: addr.isHidden, | ||
| name: addr.name, | ||
| type: P2pkhAddressType.p2pkh, | ||
| network: DogecoinNetwork.mainnet, | ||
| ); | ||
| } | ||
| }).toList(), |
There was a problem hiding this comment.
this was for bitcoin cash for a reason, but here I believe it can be just snp?.addresses like litecoin, right?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue Number (if Applicable): Fixes #
Description
Please include a summary of the changes and which issue is fixed / feature is added.
Pull Request - Checklist