Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

(GH-702) added documentation for TeamCity #707

Merged
merged 1 commit into from
Oct 7, 2020

Conversation

nils-a
Copy link
Contributor

@nils-a nils-a commented Oct 7, 2020

Seems exposing vcsroot.branch is required for Cake.Recipe to run.

fixes #702

@gep13
Copy link
Member

gep13 commented Oct 7, 2020

@nils-a thanks for this, really appreciate it!

Does this configuration go into a file in the repository, or does this go into a build configuration within TeamCity? Historically, TeamCity was very much UI driven. How would I take have you have provided here and get it into a build?

@nils-a
Copy link
Contributor Author

nils-a commented Oct 7, 2020

@gep13 no, that's the DSL, as displayed in TeamCity - as far as I see the DSL can be edited in the UI but not checked into the repository like the others. (Probably should mention that, though.)

@pascalberger
Copy link
Member

TeamCity can store its configration in a VCS, see https://www.jetbrains.com/help/teamcity/storing-project-settings-in-version-control.html. But I would suggest to keep it to the user how he uses TeamCity (through UI, with settings stored in XML, with settings stored in Kotlin)

@nils-a
Copy link
Contributor Author

nils-a commented Oct 7, 2020

@gep13 @pascalberger I have added a sentence to explain the exported Kotlin DSL.

Should we better use screenshots to document this?

@gep13
Copy link
Member

gep13 commented Oct 7, 2020

@nils-a screenshots never hurt, so if you wanted to add some here, I certainly wouldn't say no 😄

@nils-a
Copy link
Contributor Author

nils-a commented Oct 7, 2020

@gep13 added a textual guideline thru the TeamCity-UI, including two screenshots. (and I was able to add the img-responsive-class thanks the video from the week before 😃 )

Copy link
Member

@gep13 gep13 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@gep13 gep13 merged commit f7b0621 into cake-contrib:develop Oct 7, 2020
@gep13
Copy link
Member

gep13 commented Oct 7, 2020

@nils-a thanks for getting this documented!

@nils-a nils-a deleted the feature/GH-702 branch February 22, 2021 18:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

TeamCity documentation is missing under CI-Systems
3 participants