(GH-182) added tags to exclusionlist #183
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cake-addin, cake-module and cake-recipe
augustoproiete
approved these changes
Feb 28, 2021
| @@ -41,6 +41,9 @@ | |||
| "Build", | |||
| "Cake", | |||
| "Cake-Contrib", | |||
| "Script" | |||
| "Script", | |||
| "Cake-Addin", | |||
There was a problem hiding this comment.
LGTM, though @Jericho needs to double-check the exclusion is not case sensitive because existing addins are using the tags all in lowercase e.g. cake-addin instead of Cake-Addin.
There was a problem hiding this comment.
I checked - saw the discussion in the other PR 😄
There was a problem hiding this comment.
Tag exclusion is indeed case-insensitive.
Jericho
approved these changes
Mar 1, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
cake-addin, cake-module and cake-recipe
fixes #182