Add Cake.Sitecore to blacklist

[pascalberger]

Add Cake.Sitecore to blacklist since it is not an addin but a recipe script.

It is recognized as addin, since it contains some tools. A better way than blacklisting would be to improve detection of recipe packages.

[Jericho]

I'm not sure I follow. Cake.SiteCore is categorized as a recipe:

Maybe you meant Cake.SitecoreCodegen which is categorized as an addin?

[gep13]

@Jericho if this PR is merged:

cake-build/website#1155

Would AddinDiscoverer create a PR to add it back again?

[pascalberger]

I'm not sure I follow. Cake.SiteCore is categorized as a recipe:

Then probably its fine and this PR is not required. What @gep13 said on the website it is currently listed as an addin and I wanted to avoid that addin discoverer creates a PR if we remove the file.

[Jericho]

In other words: does the discoverer create YAML files for recipes? Good question. Give me a few minutes I'll double check.

[Jericho]

Answer: no, the discoverer does not create YAML files for recipes. We only create/update YAML files for NuGet packages that have been categorized as addins (here):

The import line of code is:

    .Where(addin => addin.Type == AddinType.Addin)

Therefore, feel free to delete the YAML file for the Cake.SiteCore recipe. It will not be recreated by the dicoverer.

[Jericho]

This brings up an interesting question: should the discoverer actively delete YAML files for recipes?

Currently we delete YAML files when an addin becomes "deprecated" or is removed from NuGet.

[gep13]

Yes, I think that would be a good addition.

[pascalberger]

This brings up an interesting question: should the discoverer actively delete YAML files for recipes?

In the future I would like to have recipes (and modules) listed on the website and not only addins (therefore the name switch from /addins to /extensions). But it is not implemented yet.

[Jericho]

In the future I would like to have recipes (and modules) listed on the website and not only addins

In other words, you think the discoverer should not delete YAML files for recipes? If that's the case, discoverer should add/modify YAML for the recipes as well, don't you think?

[pascalberger]

In other words, you think the discoverer should not delete YAML files for recipes? If that's the case, discoverer should add/modify YAML for the recipes as well, don't you think?

We need to first implement it on the website. Don't know yet what best design ist (same yaml structure in the same folder, a different file somewhere else, etc).