Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Exclude Cake.Task addins #117

Closed
Jericho opened this issue Sep 15, 2020 · 5 comments · Fixed by #119
Closed

Exclude Cake.Task addins #117

Jericho opened this issue Sep 15, 2020 · 5 comments · Fixed by #119
Assignees
@Jericho
Labels
enhancement New feature or request
Milestone
3.47.0

Comments

@Jericho
Copy link
Member

Jericho commented Sep 15, 2020 •
edited
Loading

@pascalberger I can certainly exclude each of your plugins one by one, but is there some naming convention that they follow and would make exclusion simpler? Something like Cake.Task.* or something?

cake-build/website#900
cake-build/website#898
cake-build/website#896
cake-build/website#894
cake-build/website#892
@Jericho Jericho added the enhancement New feature or request label Sep 15, 2020
@Jericho Jericho added this to the 3.47.0 milestone Sep 15, 2020
@Jericho Jericho self-assigned this Sep 15, 2020
@gep13
Copy link
Member

gep13 commented Sep 15, 2020

@Jericho I think usingCake.Task.* is a good idea.

@Jericho
Copy link
Member Author

Jericho commented Sep 16, 2020

For future reference: anybody can request an addin to be added to the exclusion list by submitting a PR with the proper modification to this file: https://github.com/cake-contrib/Cake.AddinDiscoverer/blob/develop/Source/Cake.AddinDiscoverer/exclusionlist.json

Jericho added a commit that referenced this issue Sep 16, 2020
@Jericho
(GH-117) Exclude "Cake.Task.*"
8384afc
@Jericho
Copy link
Member Author

Jericho commented Sep 16, 2020

Done. Published in 3.47.0

@Jericho Jericho closed this as completed Sep 16, 2020
@pascalberger
Copy link
Member

@Jericho This doesn't seem to work, since Addin Discoverer just created issues again for the Cake.Tasks packages (e.g. cake-build/website#1055)

@Jericho
Copy link
Member Author

Jericho commented Oct 4, 2020

I excluded Cake.Task.* but your naming convention seems to be Cake.Tasks.* (plural).

@pascalberger pascalberger mentioned this issue Oct 4, 2020
Merged
@Jericho Jericho changed the title Exclude Cake.Task plugins Exclude Cake.Task addins Oct 5, 2020
This was referenced Oct 5, 2020
Closed
Closed
Closed
Closed
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@Jericho Jericho

Labels
enhancement New feature or request
Projects
None yet
Milestone
3.47.0
Development

Successfully merging a pull request may close this issue.

(GH-117) Fix blacklist entry for Cake.Tasks.* addins pascalberger/Cake.AddinDiscoverer
3 participants
@Jericho @gep13 @pascalberger