GH4900: Add Inno Setup 7 support#4901
Conversation
devlead
left a comment
There was a problem hiding this comment.
Looks like Inno Setup 7 uses different AppIds per architecture in setup.iss: 64-bit → Inno Setup 7, 32-bit → Inno Setup 7 (32-bit). Per AppId docs, uninstall keys are {AppId}_is1, so the 32-bit installer registers as Inno Setup 7 (32-bit)_is1, not Inno Setup 7_is1. Which means we probably also should probe that key?
Yes, according to this commit, the AppId for the 32-bit version has been changed in the beta version.
Also Inno Setup (32-bit) on 32-bit Windows is the same
Sorry for not catching this issue before submitting the PR. I'll make the changes. |
|
@peymanr34 your changes have been merged, thanks for your contribution 👍 |
|
@devlead Thank you very much. |



Changes (Edited on 2026-06-24):
Added support for Inno Setup when installed in user mode.1Notes:
Footnotes
Since nobody asked for this feature I removed it to make the PR easier to review. ↩