Skip to content

GH4900: Add Inno Setup 7 support#4901

Merged
devlead merged 1 commit into
cake-build:developfrom
peymanr34:inno-setup-7
Jun 24, 2026
Merged

GH4900: Add Inno Setup 7 support#4901
devlead merged 1 commit into
cake-build:developfrom
peymanr34:inno-setup-7

Conversation

@peymanr34

@peymanr34 peymanr34 commented Jun 19, 2026

Copy link
Copy Markdown
Contributor

Changes (Edited on 2026-06-24):

  • Added Inno Setup 7 support.
  • Added support for Inno Setup when installed in user mode. 1

Notes:

  • Inno Setup 7 has both 32-bit and 64-bit editions but the previously supported versions are 32-bit only.
  • Inno Setup 7 is currently in beta and it's set to be released in 2026-06-29.
  • Fixes: Add support for Inno Setup 7 #4900

Footnotes

  1. Since nobody asked for this feature I removed it to make the PR easier to review.

@devlead devlead left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks like Inno Setup 7 uses different AppIds per architecture in setup.iss: 64-bit → Inno Setup 7, 32-bit → Inno Setup 7 (32-bit). Per AppId docs, uninstall keys are {AppId}_is1, so the 32-bit installer registers as Inno Setup 7 (32-bit)_is1, not Inno Setup 7_is1. Which means we probably also should probe that key?

@peymanr34

Copy link
Copy Markdown
Contributor Author

Looks like Inno Setup 7 uses different AppIds per architecture in setup.iss: 64-bit → Inno Setup 7, 32-bit → Inno Setup 7 (32-bit). Per AppId docs, uninstall keys are {AppId}_is1, so the 32-bit installer registers as Inno Setup 7 (32-bit)_is1, not Inno Setup 7_is1. Which means we probably also should probe that key?

Yes, according to this commit, the AppId for the 32-bit version has been changed in the beta version.

Inno Setup (64-bit) Inno Setup (32-bit)
Screenshot 2026-06-22 132340 Screenshot 2026-06-22 132259

Also Inno Setup (32-bit) on 32-bit Windows is the same Inno Setup 7 (32-bit)_is1 key which makes sense.

VirtualBox_Win10-x86_22_06_2026_13_39_05

Sorry for not catching this issue before submitting the PR. I'll make the changes.

@devlead devlead left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@devlead devlead merged commit 27bc009 into cake-build:develop Jun 24, 2026
18 checks passed
@devlead

devlead commented Jun 24, 2026

Copy link
Copy Markdown
Member

@peymanr34 your changes have been merged, thanks for your contribution 👍

@peymanr34

Copy link
Copy Markdown
Contributor Author

@devlead Thank you very much.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Add support for Inno Setup 7

2 participants