GH4055: Add task skip reason to task summary output #4056
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Original Cake output:
Spectre.Console Output with no tasks being skipped:
Spectre.Console Output with a task that is being skipped:
|
gep13
force-pushed
the
skipped_task_in_summary
branch
from
20afe86 to
ff86774
Compare
This was showing up as a warning within Visual Studio.
Via a new setting, --Settings_UseSpectreConsoleForConsoleOutput, it is now possible to output the task headers, and task summary using Spectre.Console. This allows for the easy addition of a new column in the task summary, which includes information about _why_ any given task has been skipped. The old CakeReportPrinter is still in play, but some implementation has been moved from within the DefaultExecutionStrategy to the reporter class. Depending on the setting mentioned above, either the Spectre.Console version of the reporter will be added to the IoC container, or the old version will be in place. * fixes cake-build#4055
devlead
force-pushed
the
skipped_task_in_summary
branch
from
ff86774 to
03b6647
Compare
|
@gep13 your changes have been merged, thanks for your contribution 👍 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Via a new setting, --Settings_UseSpectreConsoleForConsoleOutput, it is
now possible to output the task headers, and task summary using
Spectre.Console. This allows for the easy addition of a new column in
the task summary, which includes information about why any given task
has been skipped.
The old CakeReportPrinter is still in play, but some implementation has
been moved from within the DefaultExecutionStrategy to the reporter
class. Depending on the setting mentioned above, either the
Spectre.Console version of the reporter will be added to the IoC
container, or the old version will be in place.
Fixes #4055