-
-
Notifications
You must be signed in to change notification settings - Fork 736
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Access to ITaskSetupContext in Frosting #3946
Comments
Thank you for now I will try to use your workaround, it's very helpful. |
Shameless plug here for Cake.Console if you write this
You will get this |
devlead
added a commit
to devlead/cake
that referenced
this issue
Oct 25, 2022
devlead
added a commit
to devlead/cake
that referenced
this issue
Oct 27, 2022
devlead
added a commit
to devlead/cake
that referenced
this issue
Oct 28, 2022
devlead
added a commit
to devlead/cake
that referenced
this issue
Oct 29, 2022
devlead
added a commit
that referenced
this issue
Oct 29, 2022
GH3946: Add ISetupContext to Frosting lifetime
🎉 This issue has been resolved in version v3.0.0 🎉 The release is available on: Your GitReleaseManager bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Originally posted by @lonix1 in #1772 (comment)
A quick look at the code, it looks like currently, the SetupContext isn't passed to the Frosting setup, adding it to
IFrostingLifetime
/IFrostingSetup
would be a breaking change, so maybe first fixed in the next mayor release, or at least some more thought will need to go into it.cake/src/Cake.Frosting/Internal/FrostingEngine.cs
Line 83 in a1893a2
like it is for the teardown
cake/src/Cake.Frosting/Internal/FrostingEngine.cs
Line 89 in a1893a2
A dirty workaround, in this case, could be to register the setup task yourself.
This could be done by injecting a custom setup task in IoC and adding it and
ICakeEngine
to your own custom context. that could look something likeThe text was updated successfully, but these errors were encountered: