Feature/upgrade hc to v13 and optimize code #12
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… completed... WIP.
… to process selections which simplifies our code a bit; but the Facade is still very useful. Also simplified processing of Cursor Paginated results and Deprecated Sorting and Cursor Paging methods that will be removed in the future and recommending the now optimized/simpiflied alternatives to use SetSortingIsHandled() or access SortArgs, and use ToGraphQLConnection() respectively. Additional code cleanup and removal.
… (Cursor Paging Provider & Handler, Offset Paging Provider & Handler, Sorting Provider & Handler)... this greatly simplifies the project and better leverages/encourages the use of HC OOTB features. Some basic code organization cleanup and simplifications (Constants classes now grouped), naming improvements, etc. Cursor Paging, Offset Paging, & Sorting are all working as expected. . . . Unit Test project fails and is WIP.
… IGraphQLRepoDbMapper when it's actually requested in the signature of the resolver, with full caching to ensure reflection work is only executed once-and-only-once. Additional code cleanup, and Unit test fixes.
…Process'... and all variants. Fixed Compile, and cleaned up Release notes. Dropped HC Version to the original v13 for maximum compatibility and re-tested; everything tested successfully.
# Conflicts: # Sample.StarWars-AzureFunctions-RepoDB/GraphQLPlaygroundFunctionEndpoint.cs # Sample.StarWars-AzureFunctions-RepoDB/StarWars-AzureFunctions-RepoDB.csproj # Sample.StarWars-AzureFunctions-RepoDB/Startup.cs
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.