Skip to content

Commit

Permalink
Remove createClass, PropTypes, DOM factories, and createMixin from Re…
Browse files Browse the repository at this point in the history
…act object (facebook#9788)
  • Loading branch information
gaearon authored May 30, 2017
1 parent 319ba0b commit fedb2ff
Show file tree
Hide file tree
Showing 12 changed files with 75 additions and 1,769 deletions.
1 change: 0 additions & 1 deletion packages/react/package.json
Original file line number Diff line number Diff line change
Expand Up @@ -22,7 +22,6 @@
"node": ">=0.10.0"
},
"dependencies": {
"create-react-class": "^15.5.2",
"fbjs": "^0.8.9",
"loose-envify": "^1.1.0",
"object-assign": "^4.1.0",
Expand Down
95 changes: 1 addition & 94 deletions scripts/fiber/tests-passing.txt
Original file line number Diff line number Diff line change
Expand Up @@ -40,16 +40,6 @@ scripts/shared/__tests__/evalToString-test.js
* should support string concat (`+`)
* should throw when it finds other types

src/addons/__tests__/ReactDOMFactories-test.js
* allow factories to be called without warnings
* warns once when accessing React.DOM methods

src/isomorphic/__tests__/React-test.js
* should log a deprecation warning once when using React.createMixin
* should warn once when attempting to access React.createClass
* should warn once when attempting to access React.PropTypes
* should warn once when attempting to access React.checkPropTypes

src/isomorphic/children/__tests__/ReactChildren-test.js
* should support identity for simple
* should treat single arrayless child as being in array
Expand Down Expand Up @@ -98,7 +88,7 @@ src/isomorphic/classic/__tests__/ReactContextValidator-test.js
* should warn (but not error) if getChildContext method is missing
* should pass parent context if getChildContext method is missing

src/isomorphic/classic/class/__tests__/create-react-class-integration-test.js
src/isomorphic/classic/__tests__/createReactClassIntegration-test.js
* should throw when `render` is not specified
* should copy prop types onto the Constructor
* should warn on invalid prop types
Expand Down Expand Up @@ -203,89 +193,6 @@ src/isomorphic/classic/element/__tests__/ReactElementValidator-test.js
* does not blow up with inlined children
* does not blow up on key warning with undefined type

src/isomorphic/classic/types/__tests__/ReactPropTypes-test.js
* does not return a value from a validator
* does not throw if validator throws
* should warn for invalid strings
* should fail date and regexp correctly
* should not warn for valid values
* should be implicitly optional and not warn without values
* should warn for missing required values
* should throw if called manually in development
* should should accept any value
* should be implicitly optional and not warn without values
* should warn for missing required values
* should throw if called manually in development
* should fail for invalid argument
* should support the arrayOf propTypes
* should support arrayOf with complex types
* should warn with invalid items in the array
* should warn with invalid complex types
* should warn when passed something other than an array
* should not warn when passing an empty array
* should be implicitly optional and not warn without values
* should warn for missing required values
* should throw if called manually in development
* should support components
* should not support multiple components or scalar values
* should be able to define a single child as label
* should warn when passing no label and isRequired is set
* should be implicitly optional and not warn without values
* should warn for missing required values
* should throw if called manually in development
* should warn for invalid instances
* should not warn for valid values
* should be implicitly optional and not warn without values
* should warn for missing required values
* should throw if called manually in development
* should warn for invalid values
* should not warn for valid values
* should not warn for iterables
* should not warn for entry iterables
* should not warn for null/undefined if not required
* should warn for missing required values
* should accept empty array for required props
* should throw if called manually in development
* should fail for invalid argument
* should support the objectOf propTypes
* should support objectOf with complex types
* should warn with invalid items in the object
* should warn with invalid complex types
* should warn when passed something other than an object
* should not warn when passing an empty object
* should be implicitly optional and not warn without values
* should warn for missing required values
* should throw if called manually in development
* should warn but not error for invalid argument
* should warn for invalid values
* should not warn for valid values
* should be implicitly optional and not warn without values
* should warn for missing required values
* should throw if called manually in development
* should warn but not error for invalid argument
* should warn if none of the types are valid
* should not warn if one of the types are valid
* should be implicitly optional and not warn without values
* should warn for missing required values
* should throw if called manually in development
* should warn for non objects
* should not warn for empty values
* should not warn for an empty object
* should not warn for non specified types
* should not warn for valid types
* should warn for required valid types
* should warn for the first required type
* should warn for invalid key types
* should be implicitly optional and not warn without values
* should warn for missing required values
* should throw if called manually in development
* should warn for non-symbol
* should not warn for a polyfilled Symbol
* should have been called with the right params
* should have been called even if the prop is not present
* should have received the validator's return value
* should not warn if the validator returned null

src/isomorphic/modern/class/__tests__/ReactClassEquivalence-test.js
* tests the same thing for es6 classes and CoffeeScript
* tests the same thing for es6 classes and TypeScript
Expand Down
88 changes: 44 additions & 44 deletions scripts/rollup/results.json
Original file line number Diff line number Diff line change
@@ -1,28 +1,28 @@
{
"bundleSizes": {
"react.development.js (UMD_DEV)": {
"size": 125800,
"gzip": 31378
"size": 73848,
"gzip": 18852
},
"react.production.min.js (UMD_PROD)": {
"size": 15753,
"gzip": 5824
"size": 7756,
"gzip": 3089
},
"react-dom.development.js (UMD_DEV)": {
"size": 605005,
"gzip": 139056
"size": 605435,
"gzip": 139358
},
"react-dom.production.min.js (UMD_PROD)": {
"size": 125182,
"gzip": 39533
"size": 125246,
"gzip": 39624
},
"react-dom-server.development.js (UMD_DEV)": {
"size": 525947,
"gzip": 126689
"size": 534438,
"gzip": 129160
},
"react-dom-server.production.min.js (UMD_PROD)": {
"size": 111505,
"gzip": 34936
"size": 113386,
"gzip": 35642
},
"react-art.development.js (UMD_DEV)": {
"size": 359125,
Expand All @@ -33,60 +33,60 @@
"gzip": 29993
},
"react.development.js (NODE_DEV)": {
"size": 72595,
"gzip": 18499
"size": 64064,
"gzip": 16441
},
"react.production.min.js (NODE_PROD)": {
"size": 9195,
"gzip": 3614
"size": 6650,
"gzip": 2671
},
"React-dev.js (FB_DEV)": {
"size": 71806,
"gzip": 18233
"size": 63268,
"gzip": 16164
},
"React-prod.js (FB_PROD)": {
"size": 36172,
"gzip": 9226
"size": 30387,
"gzip": 7986
},
"ReactDOMStack-dev.js (FB_DEV)": {
"size": 495315,
"gzip": 118265
"size": 503788,
"gzip": 120786
},
"ReactDOMStack-prod.js (FB_PROD)": {
"size": 353140,
"gzip": 84785
"size": 360176,
"gzip": 86700
},
"react-dom.development.js (NODE_DEV)": {
"size": 562575,
"gzip": 128975
"size": 563003,
"gzip": 129288
},
"react-dom.production.min.js (NODE_PROD)": {
"size": 121395,
"gzip": 38183
"size": 121459,
"gzip": 38279
},
"ReactDOMFiber-dev.js (FB_DEV)": {
"size": 563564,
"gzip": 129481
"size": 563992,
"gzip": 129811
},
"ReactDOMFiber-prod.js (FB_PROD)": {
"size": 422947,
"gzip": 96357
"size": 423415,
"gzip": 96616
},
"react-dom-server.development.js (NODE_DEV)": {
"size": 474510,
"gzip": 114092
"size": 482987,
"gzip": 116600
},
"react-dom-server.production.min.js (NODE_PROD)": {
"size": 105880,
"gzip": 32763
"size": 107761,
"gzip": 33495
},
"ReactDOMServerStack-dev.js (FB_DEV)": {
"size": 455996,
"gzip": 109840
"size": 464469,
"gzip": 112326
},
"ReactDOMServerStack-prod.js (FB_PROD)": {
"size": 334101,
"gzip": 80467
"size": 341137,
"gzip": 82395
},
"ReactARTStack-dev.js (FB_DEV)": {
"size": 143177,
Expand Down Expand Up @@ -157,12 +157,12 @@
"gzip": 2234
},
"ReactDOMServerStream-dev.js (FB_DEV)": {
"size": 472979,
"gzip": 113937
"size": 481456,
"gzip": 116430
},
"ReactDOMServerStream-prod.js (FB_PROD)": {
"size": 345258,
"gzip": 83320
"size": 352294,
"gzip": 85249
},
"ReactNativeStack-dev.js (RN_DEV)": {
"size": 182305,
Expand Down
Loading

0 comments on commit fedb2ff

Please sign in to comment.