Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Group domain game projects and tests into a single one #566

Closed
wants to merge 30 commits into from

Full code cleanup

ff14cc3
Select commit
Loading
Failed to load commit list.
Closed

Group domain game projects and tests into a single one #566

Full code cleanup
ff14cc3
Select commit
Loading
Failed to load commit list.
codefactor.io / CodeFactor failed Mar 7, 2024 in 5s

46 issues fixed. 101 issues found.

Annotations

Check notice on line 34 in tests/NeoServer.Game.Tests/Creature/Players/PlayerStatsTests.cs

See this annotation in the file changed.

@codefactor-io codefactor-io / CodeFactor

tests/NeoServer.Game.Tests/Creature/Players/PlayerStatsTests.cs#L34 

The code must not contain multiple blank lines in a row. (SA1507)

Check notice on line 683 in tests/NeoServer.Game.Tests/Creature/Players/PlayerPartyTests.cs

See this annotation in the file changed.

@codefactor-io codefactor-io / CodeFactor

tests/NeoServer.Game.Tests/Creature/Players/PlayerPartyTests.cs#L683 

The code must not contain multiple blank lines in a row. (SA1507)

Check notice on line 58 in benchmarks/NeoServer.Benchmarks/DIFramework/AutoFacVsMicrosoft.cs

See this annotation in the file changed.

@codefactor-io codefactor-io / CodeFactor

benchmarks/NeoServer.Benchmarks/DIFramework/AutoFacVsMicrosoft.cs#L58 

A C# document may only contain a single class at the root level unless all of the classes are partial and are of the same type. (SA1402)

Check notice on line 136 in tests/NeoServer.Game.Tests/Creature/Players/PlayerVipListTests.cs

See this annotation in the file changed.

@codefactor-io codefactor-io / CodeFactor

tests/NeoServer.Game.Tests/Creature/Players/PlayerVipListTests.cs#L136 

The code must not contain multiple blank lines in a row. (SA1507)

Check notice on line 71 in tests/NeoServer.Game.Tests/Creature/Players/PlayerMoveItemTests.cs

See this annotation in the file changed.

@codefactor-io codefactor-io / CodeFactor

tests/NeoServer.Game.Tests/Creature/Players/PlayerMoveItemTests.cs#L71 

The code must not contain multiple blank lines in a row. (SA1507)

Check notice on line 46 in tests/NeoServer.Game.Tests/Creature/Players/PlayerMoveItemTests.cs

See this annotation in the file changed.

@codefactor-io codefactor-io / CodeFactor

tests/NeoServer.Game.Tests/Creature/Players/PlayerMoveItemTests.cs#L46 

The code must not contain multiple blank lines in a row. (SA1507)

Check notice on line 147 in tests/NeoServer.Game.Tests/Creature/Players/PlayerMoveItemTests.cs

See this annotation in the file changed.

@codefactor-io codefactor-io / CodeFactor

tests/NeoServer.Game.Tests/Creature/Players/PlayerMoveItemTests.cs#L147 

The code must not contain multiple blank lines in a row. (SA1507)

Check notice on line 28 in src/GameWorldSimulator/NeoServer.Game/Common/Helpers/RandomIdGenerator.cs

See this annotation in the file changed.

@codefactor-io codefactor-io / CodeFactor

src/GameWorldSimulator/NeoServer.Game/Common/Helpers/RandomIdGenerator.cs#L28 

A C# document may only contain a single class at the root level unless all of the classes are partial and are of the same type. (SA1402)

Check notice on line 80 in src/GameWorldSimulator/NeoServer.Game/Item/Factories/ItemFactory.cs

See this annotation in the file changed.

@codefactor-io codefactor-io / CodeFactor

src/GameWorldSimulator/NeoServer.Game/Item/Factories/ItemFactory.cs#L80 

The code must not contain multiple blank lines in a row. (SA1507)

Check notice on line 12 in src/GameWorldSimulator/NeoServer.Game/Item/Factories/GroundFactory.cs

See this annotation in the file changed.

@codefactor-io codefactor-io / CodeFactor

src/GameWorldSimulator/NeoServer.Game/Item/Factories/GroundFactory.cs#L12 

The code must not contain multiple blank lines in a row. (SA1507)

Check notice on line 690 in src/GameWorldSimulator/NeoServer.Game/World/Models/Tiles/DynamicTile.cs

See this annotation in the file changed.

@codefactor-io codefactor-io / CodeFactor

src/GameWorldSimulator/NeoServer.Game/World/Models/Tiles/DynamicTile.cs#L625-L690 

Complex Method

Check notice on line 207 in src/GameWorldSimulator/NeoServer.Game/World/Map/Map.cs

See this annotation in the file changed.

@codefactor-io codefactor-io / CodeFactor

src/GameWorldSimulator/NeoServer.Game/World/Map/Map.cs#L144-L207 

Complex Method

Check notice on line 28 in src/GameWorldSimulator/NeoServer.Game/Combat/Validation/AttackValidation.cs

See this annotation in the file changed.

@codefactor-io codefactor-io / CodeFactor

src/GameWorldSimulator/NeoServer.Game/Combat/Validation/AttackValidation.cs#L10-L28 

Complex Method

Check notice on line 21 in src/GameWorldSimulator/NeoServer.Game/Item/Items/Attributes/Protection.cs

See this annotation in the file changed.

@codefactor-io codefactor-io / CodeFactor

src/GameWorldSimulator/NeoServer.Game/Item/Items/Attributes/Protection.cs#L21 

The code must not contain multiple blank lines in a row. (SA1507)

Check notice on line 38 in src/GameWorldSimulator/NeoServer.Game/Common/Parsers/SlotTypeParser.cs

See this annotation in the file changed.

@codefactor-io codefactor-io / CodeFactor

src/GameWorldSimulator/NeoServer.Game/Common/Parsers/SlotTypeParser.cs#L9-L38 

Complex Method

Check notice on line 185 in src/GameWorldSimulator/NeoServer.Game/Creature/Models/Bases/Creature.cs

See this annotation in the file changed.

@codefactor-io codefactor-io / CodeFactor

src/GameWorldSimulator/NeoServer.Game/Creature/Models/Bases/Creature.cs#L171-L185 

Complex Method

Check notice on line 107 in src/GameWorldSimulator/NeoServer.Game/World/Models/Tiles/BaseTile.cs

See this annotation in the file changed.

@codefactor-io codefactor-io / CodeFactor

src/GameWorldSimulator/NeoServer.Game/World/Models/Tiles/BaseTile.cs#L107 

The code must not contain multiple blank lines in a row. (SA1507)

Check notice on line 21 in src/GameWorldSimulator/NeoServer.Game/World/Models/Spawns/Spawn.cs

See this annotation in the file changed.

@codefactor-io codefactor-io / CodeFactor

src/GameWorldSimulator/NeoServer.Game/World/Models/Spawns/Spawn.cs#L21 

A C# document may only contain a single class at the root level unless all of the classes are partial and are of the same type. (SA1402)

Check notice on line 143 in src/GameWorldSimulator/NeoServer.Game/World/Map/Map.cs

See this annotation in the file changed.

@codefactor-io codefactor-io / CodeFactor

src/GameWorldSimulator/NeoServer.Game/World/Map/Map.cs#L110-L143 

Complex Method

Check notice on line 113 in src/GameWorldSimulator/NeoServer.Game/World/Models/Tiles/BaseTile.cs

See this annotation in the file changed.

@codefactor-io codefactor-io / CodeFactor

src/GameWorldSimulator/NeoServer.Game/World/Models/Tiles/BaseTile.cs#L65-L113 

Complex Method

Check notice on line 94 in src/GameWorldSimulator/NeoServer.Game/Item/Items/Weapons/MeleeWeapon.cs

See this annotation in the file changed.

@codefactor-io codefactor-io / CodeFactor

src/GameWorldSimulator/NeoServer.Game/Item/Items/Weapons/MeleeWeapon.cs#L94 

Insert parentheses within the arithmetic expression to declare the operator precedence. (SA1407)

Check notice on line 127 in src/GameWorldSimulator/NeoServer.Game/Creature/Services/CoinTransaction.cs

See this annotation in the file changed.

@codefactor-io codefactor-io / CodeFactor

src/GameWorldSimulator/NeoServer.Game/Creature/Services/CoinTransaction.cs#L54-L127 

Complex Method

Check notice on line 17 in src/GameWorldSimulator/NeoServer.Game/Item/Items/Containers/Depot.cs

See this annotation in the file changed.

@codefactor-io codefactor-io / CodeFactor

src/GameWorldSimulator/NeoServer.Game/Item/Items/Containers/Depot.cs#L17 

The code must not contain multiple blank lines in a row. (SA1507)

Check notice on line 142 in src/GameWorldSimulator/NeoServer.Game/Creature/Npcs/Npc.cs

See this annotation in the file changed.

@codefactor-io codefactor-io / CodeFactor

src/GameWorldSimulator/NeoServer.Game/Creature/Npcs/Npc.cs#L111-L142 

Complex Method

Check notice on line 26 in src/GameWorldSimulator/NeoServer.Game/Creature/Vocation/VocationStore.cs

See this annotation in the file changed.

@codefactor-io codefactor-io / CodeFactor

src/GameWorldSimulator/NeoServer.Game/Creature/Vocation/VocationStore.cs#L26 

The code must not contain multiple blank lines in a row. (SA1507)
View more details on codefactor.io