Skip to content

fix: INVALID_PACKAGE on large plugin_package files #6

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
Corb3nik merged 2 commits into from
Feb 22, 2025
Merged

fix: INVALID_PACKAGE on large plugin_package files #6

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
4ac350f
fix: INVALID_PACKAGE on large plugin_package file
bebiksior Feb 21, 2025
4056802
Bump to 0.1.1
Corb3nik Feb 22, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
{
"name": "@caido-community/dev",
"version": "0.1.0",
"version": "0.1.1",
"description": "Development tools for building Caido plugins",
"type": "module",
"exports": {
Expand Down
22 changes: 13 additions & 9 deletions src/bundle/index.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -91,13 +91,17 @@ export async function bundlePackage(options: {
// Write zip file to dist directory
const zipPath = path.join(distDir, "plugin_package.zip");
const zipFile = await fs.open(zipPath, "w");
zip
.generateNodeStream({
type: "nodebuffer",
streamFiles: true,
})
.pipe(zipFile.createWriteStream())
.on("finish", () => {
logSuccess("Plugin package zip file created successfully");
});
await new Promise<void>((resolve, reject) => {
zip
.generateNodeStream({
type: "nodebuffer",
streamFiles: true,
})
.pipe(zipFile.createWriteStream())
.on("finish", () => {
logSuccess("Plugin package zip file created successfully");
resolve();
})
.on("error", reject);
});
}