Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(*): handle more inline situations in API docs generation #442

Merged
merged 1 commit into from
Jan 20, 2021

Conversation

iawia002
Copy link

What this PR does / why we need it:

continue #437

Which issue(s) this PR is related to (optional, link to 3rd issue(s)):

Fixes #

Reference to #

Special notes for your reviewer:

/cc @xpofei

Release note:

NONE

@caicloud-bot caicloud-bot added the release-note-none Denotes a PR that doesn't merit a release note. label Jan 20, 2021
@caicloud-bot caicloud-bot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Jan 20, 2021
@iawia002
Copy link
Author

/cherrypick release-0.3

@caicloud-bot
Copy link
Contributor

@iawia002: once the present PR merges, I will cherry-pick it on top of release-0.3 in a new PR and assign it to you.

In response to this:

/cherrypick release-0.3

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@xpofei
Copy link
Contributor

xpofei commented Jan 20, 2021

/lgtm

@caicloud-bot caicloud-bot added the lgtm Indicates that a PR is ready to be merged. label Jan 20, 2021
@iawia002
Copy link
Author

/approve

@caicloud-bot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: iawia002, xpofei

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@caicloud-bot caicloud-bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jan 20, 2021
@caicloud-bot caicloud-bot merged commit ba19fa8 into caicloud:master Jan 20, 2021
@iawia002 iawia002 deleted the fix-inline branch January 20, 2021 09:10
@caicloud-bot
Copy link
Contributor

@iawia002: new pull request created: #444

In response to this:

/cherrypick release-0.3

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. release-note-none Denotes a PR that doesn't merit a release note. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants