Skip to content

Feature/undo #26

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 26 commits into
base: master
Choose a base branch
from
Open

Feature/undo #26

wants to merge 26 commits into from

Conversation

TheBukrek
Copy link
Collaborator

Added undo feature and fixed initial game state.

metinkok and others added 24 commits December 13, 2020 09:33
Added feature undo
f14dd9e
Fixed bug when a kicked pawn returns it returns on the pawn who kicke…
8382762 
…d it
Removed comment which I wrote as reminder
1bb2e26
Added spaces and brackets for better reading
938b1d5
Removed unnecessary Alert in undo
8563c96
If conditions about special pieces simplified
53b8091
Added more spaces for better reading
52de984
Changed names of booleans playerKicked and computerKicked with more u…
ce96d02 
…nderstandable ones
Repeating code block added inside a method and that method called ins…
e7a8363 
…tead of code block
Added space for better reading
061ab77
Removed unsused boolean
de68ba7
Changed getCoordinate method to static for test
bd1e286
Added some tests
2ae1d44
Removed unnecessary import
63a0d3e
Fixed indentation, spaces and new lines according to review and fixed…
8df3a64 
… crash when no moves to undo
Fixed failing tests about protected method
c880365
Added some more tests
b4c296c
Added special piecess as constants
230c10a
Changed if else if statements in getCoordinate method to switch case …
cf62597 
…statements
Fixed spacing
b5e5be3
@TheBukrek
added undo button and class
966cfce
@TheBukrek
Implemented Undo class and added some methods to help undo feature to…
1838e54 
… Board class fixed queens position for black side.
@TheBukrek
Added tests
6e63242
@TheBukrek
Merge branch 'feature/undo' of https://github.com/cagdasgerede/JavaChess
20cbbd4 
 into feature/undo

# Conflicts:
#	src/main/java/pl/nogacz/chess/application/ChessNotation.java
#	src/main/java/pl/nogacz/chess/application/Design.java
#	src/main/java/pl/nogacz/chess/application/menu/Undo.java
#	src/main/java/pl/nogacz/chess/board/Board.java
@TheBukrek TheBukrek requested a review from cagdasgerede April 11, 2021 00:29
@TheBukrek TheBukrek requested review from cagdasgerede and removed request for cagdasgerede April 11, 2021 11:43
@cagdasgerede
Copy link
Owner

@TheBukrek
Yaptığın değişiklikleri anlattığın ve oyunu çalıştırıp demo yaptığın kısa bir video çekip YouTube linkini buradan paylaş.

@TheBukrek
Copy link
Collaborator Author

https://youtu.be/AZaJsFi1-pg

@TheBukrek TheBukrek assigned cagdasgerede and unassigned TheBukrek Apr 16, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cagdasgerede cagdasgerede Awaiting requested review from cagdasgerede

At least 1 approving review is required to merge this pull request.

Assignees

@cagdasgerede cagdasgerede

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@TheBukrek @cagdasgerede