Skip to content

ci: run CI on pushes to v3 - #690

Merged
Kamirus merged 1 commit into
mainfrom
kamil/ci-v3-push-trigger
Aug 6, 2026
Merged

ci: run CI on pushes to v3#690
Kamirus merged 1 commit into
mainfrom
kamil/ci-v3-push-trigger

Conversation

@Kamirus

@Kamirus Kamirus commented Aug 6, 2026

Copy link
Copy Markdown
Collaborator

Pushing to v3 ran no checks at all. ci.yml, cli-bundle.yml and mops-test.yml trigger on pushes to main/master and on pull_request, so a merge into the integration branch was validated only by whichever PR happened to be based on it next — and when something breaks that way, the failure surfaces on an unrelated PR and is awkward to attribute to the merge that caused it.

Adding v3 to all three workflows behind the required checks rather than to ci.yml alone: ci-ok, ci-ok-cli and ci-ok-mops come from three separate files, so touching one would leave two of the three required checks unrun on a v3 push. code-quality.yml is included for parity — it already runs on main pushes and is cheap.

This matters more now that admin bypass is disabled on both branches: everything reaches v3 through a PR, and the post-merge state of the branch should be verified in its own right rather than inferred.

No behavior change for PRs — those already ran on pull_request regardless of target branch.

The v3 integration branch ran nothing on push: ci.yml and friends trigger on
main/master pushes and on pull_request, so a merge into v3 was only ever
validated by whichever PR happened to be based on it afterwards — and a
failure there is hard to attribute to the merge that caused it.

Added to all three workflows behind the required checks (ci-ok, ci-ok-cli,
ci-ok-mops) rather than ci.yml alone, so a v3 push is checked the same way a
main push is, plus code-quality for parity.
@github-actions

github-actions Bot commented Aug 6, 2026

Copy link
Copy Markdown
Contributor

Cursor AI review

👍 APPROVE — looks safe to merge

Category Assessment Details
Summary Adds v3 to the push.branches filter in ci.yml, cli-bundle.yml, mops-test.yml, and code-quality.yml so post-merge pushes to the integration branch run the same checks as main/master.
Code Quality Four one-line additions; scoped to the workflows that emit required ci-ok* jobs plus code-quality for parity — no speculative workflow churn.
Consistency Same branch list pattern as existing main/master entries in all four files; pull_request triggers untouched. Confirmed ci-ok / ci-ok-cli / ci-ok-mops live in the three updated required-check workflows.
Security Diff only extends push.branches; permissions: contents: read unchanged in ci/cli-bundle/mops-test; no pull_request_target, secrets, or action-pin changes. release.yml / deploy paths not touched.
Tests CI/YAML-only; no app code. Behavior verified from patches vs Head workflow on: blocks — push to v3 now matches main/master; PR runs already covered by existing pull_request.
Maintainability Minimal, obvious trigger update; keeps required-check coverage aligned across the three workflow files that define them.

Verdict

Decision: APPROVE
Risk: Very Low
Reason: Additive CI trigger for an existing branch with no permission, secret, or deploy-pipeline changes; PR event behavior is unchanged.


Generated for commit 3b30b5b

@automation-sa-sre automation-sa-sre left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Automated approval: the AI review verdict for 3b30b5b is APPROVE. See the "Cursor AI review" comment for details.

@Kamirus
Kamirus enabled auto-merge (squash) August 6, 2026 15:26
@Kamirus
Kamirus merged commit 477ab05 into main Aug 6, 2026
26 of 27 checks passed
@Kamirus
Kamirus deleted the kamil/ci-v3-push-trigger branch August 6, 2026 15:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants