ci: run CI on pushes to v3 - #690
Merged
Merged
Conversation
The v3 integration branch ran nothing on push: ci.yml and friends trigger on main/master pushes and on pull_request, so a merge into v3 was only ever validated by whichever PR happened to be based on it afterwards — and a failure there is hard to attribute to the merge that caused it. Added to all three workflows behind the required checks (ci-ok, ci-ok-cli, ci-ok-mops) rather than ci.yml alone, so a v3 push is checked the same way a main push is, plus code-quality for parity.
Contributor
Cursor AI review👍 APPROVE — looks safe to merge
VerdictDecision: APPROVE Generated for commit 3b30b5b |
automation-sa-sre
approved these changes
Aug 6, 2026
automation-sa-sre
left a comment
There was a problem hiding this comment.
Automated approval: the AI review verdict for 3b30b5b is APPROVE. See the "Cursor AI review" comment for details.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Pushing to
v3ran no checks at all.ci.yml,cli-bundle.ymlandmops-test.ymltrigger on pushes tomain/masterand onpull_request, so a merge into the integration branch was validated only by whichever PR happened to be based on it next — and when something breaks that way, the failure surfaces on an unrelated PR and is awkward to attribute to the merge that caused it.Adding
v3to all three workflows behind the required checks rather than toci.ymlalone:ci-ok,ci-ok-cliandci-ok-mopscome from three separate files, so touching one would leave two of the three required checks unrun on av3push.code-quality.ymlis included for parity — it already runs onmainpushes and is cheap.This matters more now that admin bypass is disabled on both branches: everything reaches
v3through a PR, and the post-merge state of the branch should be verified in its own right rather than inferred.No behavior change for PRs — those already ran on
pull_requestregardless of target branch.