Skip to content

Commit

Permalink
style: Errors should start with lowercase
Browse files Browse the repository at this point in the history
Signed-off-by: AlexNg <contact@ngjx.org>
  • Loading branch information
caffeine-addictt committed Aug 30, 2024
1 parent fcb1c6e commit f424159
Show file tree
Hide file tree
Showing 5 changed files with 19 additions and 19 deletions.
4 changes: 2 additions & 2 deletions cmd/commands/version_test.go
Original file line number Diff line number Diff line change
Expand Up @@ -15,10 +15,10 @@ func TestVersionOut(t *testing.T) {
}

if stdout != global.Version+"\n" {
t.Errorf("Expected version %s, got %s", global.Version, stdout)
t.Errorf("expected version %s, got %s", global.Version, stdout)
}

if stderr != "" {
t.Fatalf("Expected no stderr, got %s", err)
t.Fatalf("expected no stderr, got %s", err)
}
}
12 changes: 6 additions & 6 deletions cmd/helpers/testing_test.go
Original file line number Diff line number Diff line change
Expand Up @@ -17,15 +17,15 @@ func TestExecuteCommandCapturesStderr(t *testing.T) {

stdout, stderr, err := helpers.ExecuteCommand(&dummyCmd, []string{}, "")
if err != nil {
t.Fatalf("Failed to execute command: %v", stderr)
t.Fatalf("failed to execute command: %v", stderr)
}

if stderr != msg {
t.Fatalf("Expected stderr to be '%s', got '%s'", msg, stderr)
t.Fatalf("expected stderr to be '%s', got '%s'", msg, stderr)
}

if stdout != "" {
t.Fatalf("Expected stdout to be empty, got '%s'", stdout)
t.Fatalf("expected stdout to be empty, got '%s'", stdout)
}
}

Expand All @@ -39,14 +39,14 @@ func TestExecuteCommandCapturesStdout(t *testing.T) {

stdout, stderr, err := helpers.ExecuteCommand(&dummyCmd, []string{}, "")
if err != nil {
t.Fatalf("Failed to execute command: %v", stderr)
t.Fatalf("failed to execute command: %v", stderr)
}

if stdout != msg {
t.Fatalf("Expected stdout to be '%s', got '%s'", msg, stdout)
t.Fatalf("expected stdout to be '%s', got '%s'", msg, stdout)
}

if stderr != "" {
t.Fatalf("Expected stderr to be empty, got '%s'", stderr)
t.Fatalf("expected stderr to be empty, got '%s'", stderr)
}
}
6 changes: 3 additions & 3 deletions cmd/root_test.go
Original file line number Diff line number Diff line change
Expand Up @@ -10,14 +10,14 @@ import (
func TestRootCommandCanRun(t *testing.T) {
stdout, stderr, err := helpers.ExecuteCommand(cmd.RootCmd, []string{})
if err != nil {
t.Fatalf("Failed to run root command: %v", err)
t.Fatalf("failed to run root command: %v", err)
}

if stdout == "" {
t.Fatalf("Expected non-empty stdout, but got: %s", stdout)
t.Fatalf("expected non-empty stdout, but got: %s", stdout)
}

if stderr != "" {
t.Fatalf("Expected empty stderr, but got: %s", stderr)
t.Fatalf("expected empty stderr, but got: %s", stderr)
}
}
2 changes: 1 addition & 1 deletion cmd/utils/types/value_guard.go
Original file line number Diff line number Diff line change
Expand Up @@ -55,7 +55,7 @@ func (v *ValueGuard[T]) Set(value T) error {
if v.parseValue != nil {
value, err := v.parseValue(value)
if err != nil {
return errors.Join(fmt.Errorf("Cannot set value %v", value), err)
return errors.Join(fmt.Errorf("cannot set value %v", value), err)
}

v.value = value
Expand Down
14 changes: 7 additions & 7 deletions cmd/utils/types/value_guard_test.go
Original file line number Diff line number Diff line change
Expand Up @@ -17,7 +17,7 @@ func TestNoParsing(t *testing.T) {
}

if err := v.Set("new value"); err != nil {
t.Fatalf("Failed to set value: %v", err)
t.Fatalf("failed to set value: %v", err)
}
}

Expand All @@ -33,12 +33,12 @@ func TestParsing(t *testing.T) {
}, typeString)

if err := checkValues(val, typeString, v); err != nil {
t.Fatalf("Unexpected error: %v", err)
t.Fatalf("unexpected error: %v", err)
}

// Only error when setting
if err := v.Set(val); err == nil {
t.Fatal("Expected error, got nil")
t.Fatal("expected error, got nil")
}
}

Expand All @@ -54,21 +54,21 @@ func TestParsingFailEarly(t *testing.T) {
}, typeString)

if err == nil {
t.Fatal("Expected error, got nil")
t.Fatal("expected error, got nil")
}
}

func checkValues(val, typeString string, vg *types.ValueGuard[string]) error {
if vg.Value() != val {
return fmt.Errorf("Expected %s, got %s", val, vg.Value())
return fmt.Errorf("expected %s, got %s", val, vg.Value())
}

if vg.String() != val {
return fmt.Errorf("Expected %s, got %s", val, vg.String())
return fmt.Errorf("expected %s, got %s", val, vg.String())
}

if vg.Type() != typeString {
return fmt.Errorf("Expected %s, got %s", typeString, vg.Type())
return fmt.Errorf("expected %s, got %s", typeString, vg.Type())
}

return nil
Expand Down

0 comments on commit f424159

Please sign in to comment.