Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix space between search button and input #130

Merged
merged 1 commit into from
Apr 25, 2023
Merged

Fix space between search button and input #130

merged 1 commit into from
Apr 25, 2023

Conversation

rohanmurthy
Copy link
Contributor

Noticed an annoying grey piece of UI between the search button and the input.

This change:

  • moves X button into same div as input
  • move some CSS from parent div to the child div that contains the input and X button

Before:
Screenshot 2023-04-24 at 9 37 56 PM
Screenshot 2023-04-24 at 9 37 50 PM

After:
Screenshot 2023-04-24 at 9 36 47 PM
Screenshot 2023-04-24 at 9 36 40 PM

@vercel
Copy link

vercel bot commented Apr 25, 2023 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
text-sql ✅ Ready (Inspect) Visit Preview 💬 Add feedback Apr 25, 2023 4:50am

@rohanmurthy
Copy link
Contributor Author

@asaprahul

matthewlouisbrockman
matthewlouisbrockman approved these changes Apr 25, 2023
View reviewed changes
Copy link
Collaborator

@matthewlouisbrockman matthewlouisbrockman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good catch

@matthewlouisbrockman matthewlouisbrockman merged commit 36bc2a6 into caesarHQ:main Apr 25, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@matthewlouisbrockman matthewlouisbrockman matthewlouisbrockman approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@rohanmurthy @matthewlouisbrockman