Skip to content

feat(vpn): add provider selector to VPN quick-toggle #1713

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
nouredeen06 wants to merge 2 commits into
base: main
Choose a base branch
from
Open

feat(vpn): add provider selector to VPN quick-toggle #1713

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
3055450
feat(vpn): add provider selector to VPN quick-toggle
nouredeen06 Jul 18, 2026
a416640
fix: use correct upstream VPN.qml with providers API
nouredeen06 Jul 18, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
44 changes: 44 additions & 0 deletions modules/utilities/cards/Toggles.qml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,6 +2,7 @@ pragma ComponentBehavior: Bound

import QtQuick
import QtQuick.Layouts
import QtQml
import Quickshell.Bluetooth
import Caelestia.Components
import Caelestia.Config
Expand Down Expand Up @@ -142,12 +143,55 @@ StyledRect {
DelegateChoice {
roleValue: "vpn"
delegate: Toggle {
id: vpnToggle

icon: "vpn_key"
checked: VPN.connected && VPN.status.state !== "needs-auth" && VPN.status.state !== "error"
enabled: !VPN.connecting && !VPN.disconnecting
isToggle: VPN.status.state !== "needs-auth" && VPN.status.state !== "error"
inactiveOnColour: Colours.palette.m3onSurfaceVariant
onClicked: VPN.toggle()

MouseArea {
anchors.fill: parent
acceptedButtons: Qt.RightButton
onClicked: vpnMenu.expanded = !vpnMenu.expanded
}

Menu {
id: vpnMenu

attachTo: vpnToggle
attachSideY: Menu.Top
thisSideY: Menu.Bottom
marginY: -Tokens.spacing.small

Instantiator {
model: VPN.providers
delegate: MenuItem {
id: providerItem

required property var modelData
readonly property bool isActive: modelData.providerId === VPN.selectedProvider

text: modelData.displayName || modelData.name || ("VPN " + (modelData.index + 1))
icon: "vpn_key"
trailingIcon: isActive ? "check" : ""
onClicked: VPN.setActiveProvider(modelData.index)
onIsActiveChanged: {
if (isActive)
vpnMenu.active = providerItem;
}
}
Comment thread
nouredeen06 marked this conversation as resolved.
onObjectAdded: (i, obj) => {
const item = obj as MenuItem;
vpnMenu.items = [...vpnMenu.items.slice(0, i), item, ...vpnMenu.items.slice(i)];
if (item.isActive) // qmllint disable missing-property
vpnMenu.active = item;
}
onObjectRemoved: (i, obj) => vpnMenu.items = vpnMenu.items.filter(x => x !== obj)
}
}
}
}
}
Expand Down