LyricsView remains visible when the media player is closed - #1359
Merged
soramanew merged 3 commits intoApr 2, 2026
Merged
Conversation
Collaborator
|
I forgot to merge this 😭 |
Contributor
Author
I guessed : ) |
iMithrellas
pushed a commit
to iMithrellas/shell-caelestia
that referenced
this pull request
Apr 2, 2026
Co-authored-by: 2 * r + 2 * t <61896496+soramanew@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix: Clear Lyrics When Media Player Is Closed
Fix an issue where lyrics remained visible after the media player was closed.
Problem
Video
recording_20260331_23-38-48.mp4
Fix
Reset the lyrics state when no media metadata is available by clearing the lyrics and resetting the current index.