-
Notifications
You must be signed in to change notification settings - Fork 41
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Implement copying and pasting in the SliceView #162
Implement copying and pasting in the SliceView #162
Conversation
Will review once #161 is fixed |
cadnano/fileio/v3decode.py
Outdated
assert isinstance(offset, (tuple, list)) or offset is None | ||
assert isinstance(use_undostack, bool) | ||
|
||
print('Importing to part where use_undostack is %s' % use_undostack) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
need to remove
cadnano/part/createvhelixcmd.py
Outdated
# print('and to here') | ||
# import traceback | ||
# traceback.print_stack() | ||
print('done redoing create of %s' % self.id_num) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
another residual print statement
I have a version that works in the |
949b61b
to
5efd4ab
Compare
5efd4ab
to
9055420
Compare
Since this is tagged DO NOT MERGE Should we close this? |
I tagged this to hold off on merging this so that other PRs could be merged "in order" to avoid merge conflicts – and because the base of this PR needed to be updated to merge into If the consensus is that we'd rather not have other PRs open, feel free to close this and I'll reopen or create another PR once the other PRs are merged! |
Enable copying and pasting in the SliceView. When the select tool is selected, copying a VH or group of VHs copies the VH(s) to a buffer and shows a preview of what the pasted VHs will look like. Pasting ensures that the VHs are pasted in the correct position for their parity. Furthermore, pasting (either via clicking or via the context menu) is disabled if pasting would be illegal (i.e. if pasting would result in a VH being placed on top of another VH).
Add lattice coordinates to coordinates_to_vhid so that conflicting VHs can be detected
4769654
to
825c51c
Compare
Enable copying and pasting in the SliceView. When the select tool is selected, copying a VH or group of VHs copies the VH(s) to a buffer and shows a preview of what the pasted VHs will look like.
Pasting ensures that the VHs are pasted in the correct position for their parity. Furthermore, pasting (either via clicking or via the context menu) is disabled if pasting would be illegal (i.e. if pasting would result in a VH being placed on top of another VH).
This PR includes changes made in #156. It also includes a commit from #161 as these changes build on changes in #161.