feat: [shard-distributor]Decompress ETCD data #7405
Merged
+209
−31
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gazi-yestemirova
requested review from
3vilhamster,
Shaddoll,
davidporter-id-au,
demirkayaender,
dkrotx,
jakobht,
neil-xie,
sankari165,
shijiesheng and
taylanisikdemir
as code owners
Signed-off-by: Gaziza Yestemirova <gaziza@uber.com>
Signed-off-by: Gaziza Yestemirova <gaziza@uber.com>
gazi-yestemirova
force-pushed
the
sd/db_data_compression
branch
from
6bf25f6 to
b5f302c
Compare
dkrotx
approved these changes
Nov 3, 2025
service/sharddistributor/store/etcd/executorstore/common/compression.go
Outdated
Show resolved
Hide resolved
service/sharddistributor/store/etcd/executorstore/common/compression.go
Outdated
Show resolved
Hide resolved
service/sharddistributor/store/etcd/executorstore/common/compression.go
Outdated
Show resolved
Hide resolved
eleonoradgr
approved these changes
Nov 3, 2025
Signed-off-by: Gaziza Yestemirova <gaziza@uber.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changed?
This PR implements snappy framed decompression of data for all data written to etcd in the shard distributor store.
Implementation includes:
Compression logic will be implemented in another PR as part2.
Why?
Since we are enabling the snappy compression, we need to make sure first all the data will be decompressed before processing.
How did you test it?
unit-test and local testing
Potential risks
Release notes
Documentation Changes