fix: recover from panics on replication task processing #7396
+91
−2
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Shaddoll
requested review from
3vilhamster,
Groxx,
davidporter-id-au,
demirkayaender,
dkrotx,
jakobht,
neil-xie,
sankari165,
shijiesheng and
taylanisikdemir
as code owners
| tag.WorkflowRunID(attr.GetRunID()), | ||
| tag.Value(r), | ||
| ) | ||
| err = fmt.Errorf("handleActivityTask panic: %v", r) |
There was a problem hiding this comment.
do you mind emitting a metric indicating a panic is captured, we don't want to miss this
| func (p *taskProcessorImpl) processResponse(response *types.ReplicationMessages) { | ||
| defer func() { | ||
| if r := recover(); r != nil { | ||
| p.logger.Error("processResponse encountered panic.", tag.Value(r)) |
There was a problem hiding this comment.
same as before, if possible, can we emit a metric indicating a captured panic ?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changed?
Why?
How did you test it?
unit tests
Potential risks
Release notes
Documentation Changes