Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revert "Update CLI to use grpc transport by default" #6502

Merged
merged 2 commits into from
Nov 18, 2024
Merged

Conversation

dkrotx
Copy link
Member

@dkrotx dkrotx commented Nov 18, 2024

Reverts #6495

This break the cadence-cli usage we're promoting ourselves when we just specify localhost:tchannel_port and no transport. The worst thing is CLI doesn't warn you about bad usage or anything - it just times out.

We need to find a better solution.

Copy link
Contributor

@3vilhamster 3vilhamster left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lets revert and update docker-compose to expose both ports first

Copy link

codecov bot commented Nov 18, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 81.35%. Comparing base (0105e2d) to head (3916c07).
Report is 1 commits behind head on master.

Additional details and impacted files
Files with missing lines Coverage Δ
tools/cli/app.go 96.33% <100.00%> (ø)

... and 8 files with indirect coverage changes


Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 0105e2d...3916c07. Read the comment docs.

@dkrotx dkrotx disabled auto-merge November 18, 2024 10:12
@dkrotx dkrotx enabled auto-merge (squash) November 18, 2024 10:42
@dkrotx dkrotx merged commit 040713d into master Nov 18, 2024
19 checks passed
@dkrotx dkrotx deleted the revert-6495-grpc branch November 18, 2024 10:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants