Fix a bug where an error is improperly returned and add unit test for workflow_commands #6384
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
neil-xie
requested review from
Shaddoll,
davidporter-id-au,
Groxx,
shijiesheng,
jakobht,
3vilhamster,
sankari165,
dkrotx,
taylanisikdemir and
demirkayaender
as code owners
Shaddoll
reviewed
Oct 21, 2024
| @@ -1079,7 +1079,9 @@ func describeWorkflowHelper(c *cli.Context, wid, rid string) error { | |||
| o = resp | |||
| } else { | |||
| o, err = convertDescribeWorkflowExecutionResponse(resp, frontendClient, c) | |||
| return commoncli.Problem("WF helper describe failed: ", err) | |||
| if err != nil { | |||
Shaddoll
approved these changes
Oct 21, 2024
taylanisikdemir
approved these changes
Oct 21, 2024
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files
... and 11 files with indirect coverage changes Continue to review full report in Codecov by Sentry.
|
timl3136
approved these changes
Oct 21, 2024
abhishekj720
approved these changes
Oct 21, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changed?
Fix a bug where an error is improperly returned, it is returning error even err is nil
Add more unit test for PrintAutoResetPoints, DescribeWorkflow, DescribeWorkflowWithID, ListAllWorkflow, ConvertSearchAttributeToMapOfInterface and GetAllWorkflowIDsByQuery, GetWorkflowStatus
Why?
Increase test coverage
How did you test it?
Potential risks
Release notes
Documentation Changes