Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add test for QueryWorkflow #6348

Merged
merged 1 commit into from
Oct 9, 2024
Merged

Conversation

Shaddoll
Copy link
Member

@Shaddoll Shaddoll commented Oct 9, 2024

What changed?
Add test for QueryWorkflow

Why?
Improve testing

How did you test it?
unit tests

Potential risks

Release notes

Documentation Changes

Copy link

codecov bot commented Oct 9, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 73.97%. Comparing base (c8f19c0) to head (31a7717).
Report is 2 commits behind head on master.

Additional details and impacted files
Files with missing lines Coverage Δ
service/matching/handler/engine.go 83.70% <100.00%> (+4.01%) ⬆️

... and 11 files with indirect coverage changes


Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c8f19c0...31a7717. Read the comment docs.

@Shaddoll Shaddoll merged commit 6a5a864 into cadence-workflow:master Oct 9, 2024
20 checks passed
@Shaddoll Shaddoll deleted the test branch October 9, 2024 21:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants