[CLI] ErrorAndExit deprecated

[samkitshah1262]

Towards Issue #6317

ErrorAndExit function is deprecated. Now every error is propagated instead of exiting directly.

For best practices

How did you test it?

Potential risks

[CLAassistant]

All committers have signed the CLA.

[davidporter-id-au]

minor nit about that small chunk of commented code, otherwise LGTM, TY!

[codecov]

Codecov Report

Attention: Patch coverage is 12.42124% with 973 lines in your changes missing coverage. Please review.

Project coverage is 73.51%. Comparing base (5d8791b) to head (97fec1a).
Report is 11 commits behind head on master.

Files with missing lines	Patch %	Lines
tools/cli/workflow_commands.go	23.85%	179 Missing and 54 partials ⚠️
tools/cli/admin_commands.go	2.38%	120 Missing and 3 partials ⚠️
tools/cli/admin_kafka_commands.go	0.00%	87 Missing ⚠️
tools/cli/domain_migration_command.go	0.00%	59 Missing ⚠️
tools/cli/admin_dlq_commands.go	0.00%	56 Missing ⚠️
tools/cli/workflow_batch_commands.go	0.00%	49 Missing ⚠️
tools/cli/database.go	0.00%	45 Missing ⚠️
tools/cli/domain_utils.go	0.00%	37 Missing ⚠️
tools/cli/admin_timers.go	0.00%	33 Missing ⚠️
tools/cli/utils.go	50.84%	26 Missing and 3 partials ⚠️
... and 16 more

Additional details and impacted files

Files with missing lines	Coverage Δ
tools/cli/render.go	85.82% <0.00%> (ø)
tools/cli/cluster_commands.go	45.45% <33.33%> (-4.55%)	⬇️
tools/cli/admin_db_decode_thrift.go	70.42% <0.00%> (-2.05%)	⬇️
tools/cli/domain.go	62.85% <0.00%> (-1.85%)	⬇️
tools/cli/factory.go	2.54% <0.00%> (-0.04%)	⬇️
tools/cli/isolation-groups.go	29.19% <0.00%> (-1.53%)	⬇️
tools/cli/admin_async_queue_commands.go	0.00% <0.00%> (ø)
tools/cli/admin_task_list_commands.go	0.00% <0.00%> (ø)
tools/cli/task_list_commands.go	35.52% <16.66%> (-6.67%)	⬇️
tools/cli/admin_cluster_commands.go	20.17% <15.78%> (-2.60%)	⬇️
... and 16 more

... and 16 files with indirect coverage changes

---

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 5099fa7...97fec1a. Read the comment docs.