Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Minor fix for timer usage #6305

Merged
merged 1 commit into from
Sep 26, 2024
Merged

Minor fix for timer usage #6305

merged 1 commit into from
Sep 26, 2024

Conversation

Shaddoll
Copy link
Member

What changed?
Drain a timer before reset

Why?
Before go 1.23, the safe way to reset a timer is to drain it before resetting it. This is to set a pattern and reminder for us.

How did you test it?
existing unit tests

Potential risks

Release notes

Documentation Changes

Copy link

codecov bot commented Sep 25, 2024

Codecov Report

Attention: Patch coverage is 85.71429% with 1 line in your changes missing coverage. Please review.

Project coverage is 73.21%. Comparing base (16c5e64) to head (f7fcac4).
Report is 2 commits behind head on master.

Files with missing lines Patch % Lines
service/history/queue/timer_gate.go 85.71% 1 Missing ⚠️
Additional details and impacted files
Files with missing lines Coverage Δ
service/history/queue/timer_gate.go 93.18% <85.71%> (-3.25%) ⬇️

... and 4 files with indirect coverage changes


Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 16c5e64...f7fcac4. Read the comment docs.

@Shaddoll Shaddoll merged commit 69d2aa2 into cadence-workflow:master Sep 26, 2024
20 checks passed
@Shaddoll Shaddoll deleted the timer branch September 26, 2024 01:18
dkrotx pushed a commit to dkrotx/cadence that referenced this pull request Sep 26, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants