Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add metric for duplicate request error #6023

Merged
merged 1 commit into from
May 15, 2024
Merged

Add metric for duplicate request error #6023

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 4 additions & 0 deletions common/metrics/defs.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2020,6 +2020,7 @@ const (
PersistenceErrExecutionAlreadyStartedCounter
PersistenceErrDomainAlreadyExistsCounter
PersistenceErrBadRequestCounter
PersistenceErrDuplicateRequestCounter
PersistenceErrDBUnavailableCounter
PersistenceSampledCounter
PersistenceEmptyResponseCounter
Expand All @@ -2039,6 +2040,7 @@ const (
PersistenceErrExecutionAlreadyStartedCounterPerDomain
PersistenceErrDomainAlreadyExistsCounterPerDomain
PersistenceErrBadRequestCounterPerDomain
PersistenceErrDuplicateRequestCounterPerDomain
PersistenceErrDBUnavailableCounterPerDomain
PersistenceSampledCounterPerDomain
PersistenceEmptyResponseCounterPerDomain
Expand Down Expand Up @@ -2642,6 +2644,7 @@ var MetricDefs = map[ServiceIdx]map[int]metricDefinition{
PersistenceErrExecutionAlreadyStartedCounter: {metricName: "persistence_errors_execution_already_started", metricType: Counter},
PersistenceErrDomainAlreadyExistsCounter: {metricName: "persistence_errors_domain_already_exists", metricType: Counter},
PersistenceErrBadRequestCounter: {metricName: "persistence_errors_bad_request", metricType: Counter},
PersistenceErrDuplicateRequestCounter: {metricName: "persistence_errors_duplicate_request", metricType: Counter},
PersistenceErrDBUnavailableCounter: {metricName: "persistence_errors_db_unavailable", metricType: Counter},
PersistenceSampledCounter: {metricName: "persistence_sampled", metricType: Counter},
PersistenceEmptyResponseCounter: {metricName: "persistence_empty_response", metricType: Counter},
Expand All @@ -2660,6 +2663,7 @@ var MetricDefs = map[ServiceIdx]map[int]metricDefinition{
PersistenceErrExecutionAlreadyStartedCounterPerDomain: {metricName: "persistence_errors_execution_already_started_per_domain", metricRollupName: "persistence_errors_execution_already_started", metricType: Counter},
PersistenceErrDomainAlreadyExistsCounterPerDomain: {metricName: "persistence_errors_domain_already_exists_per_domain", metricRollupName: "persistence_errors_domain_already_exists", metricType: Counter},
PersistenceErrBadRequestCounterPerDomain: {metricName: "persistence_errors_bad_request_per_domain", metricRollupName: "persistence_errors_bad_request", metricType: Counter},
PersistenceErrDuplicateRequestCounterPerDomain: {metricName: "persistence_errors_duplicate_request_per_domain", metricRollupName: "persistence_errors_duplicate_request", metricType: Counter},
PersistenceErrDBUnavailableCounterPerDomain: {metricName: "persistence_errors_db_unavailable_per_domain", metricRollupName: "persistence_errors_db_unavailable", metricType: Counter},
PersistenceSampledCounterPerDomain: {metricName: "persistence_sampled_per_domain", metricRollupName: "persistence_sampled", metricType: Counter},
PersistenceEmptyResponseCounterPerDomain: {metricName: "persistence_empty_response_per_domain", metricRollupName: "persistence_empty_response", metricType: Counter},
Expand Down
4 changes: 4 additions & 0 deletions common/persistence/wrappers/metered/base.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -59,6 +59,8 @@
scopeWithDomainTag.IncCounter(metrics.PersistenceErrShardOwnershipLostCounterPerDomain)
case *types.EntityNotExistsError:
scopeWithDomainTag.IncCounter(metrics.PersistenceErrEntityNotExistsCounterPerDomain)
case *persistence.DuplicateRequestError:
scopeWithDomainTag.IncCounter(metrics.PersistenceErrDuplicateRequestCounterPerDomain)

Check warning on line 63 in common/persistence/wrappers/metered/base.go

View check run for this annotation

Codecov / codecov/patch

common/persistence/wrappers/metered/base.go#L62-L63 

Added lines #L62 - L63 were not covered by tests
case *persistence.TimeoutError:
scopeWithDomainTag.IncCounter(metrics.PersistenceErrTimeoutCounterPerDomain)
scopeWithDomainTag.IncCounter(metrics.PersistenceFailuresPerDomain)
Expand Down Expand Up @@ -93,6 +95,8 @@
metricsScope.IncCounter(metrics.PersistenceErrShardOwnershipLostCounter)
case *types.EntityNotExistsError:
metricsScope.IncCounter(metrics.PersistenceErrEntityNotExistsCounter)
case *persistence.DuplicateRequestError:
metricsScope.IncCounter(metrics.PersistenceErrDuplicateRequestCounter)

Check warning on line 99 in common/persistence/wrappers/metered/base.go

View check run for this annotation

Codecov / codecov/patch

common/persistence/wrappers/metered/base.go#L98-L99 

Added lines #L98 - L99 were not covered by tests
case *persistence.TimeoutError:
metricsScope.IncCounter(metrics.PersistenceErrTimeoutCounter)
metricsScope.IncCounter(metrics.PersistenceFailures)
Expand Down
Loading