[history] add domain status check in taskfilter #5140
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
shijiesheng
force-pushed
the
taskallocator-refactor
branch
from
a74cb9a to
4a3bde3
Compare
shijiesheng
changed the title
Shaddoll
reviewed
Mar 8, 2023
| @@ -514,24 +514,6 @@ func newTransferQueueStandbyProcessor( | |||
| if !ok { | |||
| return false, errUnexpectedQueueTask | |||
| } | |||
| if task.TaskType == persistence.TransferTaskTypeCloseExecution || | |||
There was a problem hiding this comment.
These logic was put here on purpose, because we don't want to hide it
… transfer task queues
shijiesheng
force-pushed
the
taskallocator-refactor
branch
from
900d563 to
c9866ae
Compare
Shaddoll
approved these changes
Mar 9, 2023
| domainEntry, err := shard.GetDomainCache().GetDomainByID(domainID) | ||
| if err != nil { | ||
| if _, ok := err.(*types.EntityNotExistsError); ok { | ||
| return true, nil |
There was a problem hiding this comment.
Should we be more conservative here? Normally we never delete domains
There was a problem hiding this comment.
If we have a timer and we cannot find the domain, something must be wrong.
| @@ -189,3 +191,20 @@ func (t *taskAllocatorImpl) Lock() { | |||
| func (t *taskAllocatorImpl) Unlock() { | |||
| t.locker.Unlock() | |||
| } | |||
|
|
|||
| // isDomainNotRegistered checks either if domain does not exist or is in deprecated or deleted status | |||
| func isDomainNotRegistered(shard shard.Context, domainID string) (bool, error) { | |||
There was a problem hiding this comment.
Let's change this to isDomainDeprecated
Groxx
pushed a commit
that referenced
this pull request
Mar 17, 2023
What changed? add domain status check in taskAllocator verification Why? tasks in queues should drop for deprecated or deleted domains
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changed?
Why?
How did you test it?
Potential risks
Release notes
Documentation Changes