Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add 3 tags to support adding logs for every manual access #5112

Conversation

bowenxia
Copy link
Member

@bowenxia bowenxia commented Feb 22, 2023

What changed?
add 3 tags to support adding logs for every manual access

  1. RequestCaller: string tag, returns the name of the service making this request
  2. ActorID: string tag, returns the user id of the actor to the request
  3. HandlerCall: string tag: returns tag for the API name of a request

Why?
Wanted to log manual accesses (inside the authorizer) that needs the attributes above, but there were not such attributes in tags.go file.

How did you test it?
unit test

Potential risks

Release notes

Documentation Changes

@coveralls
Copy link

coveralls commented Feb 22, 2023

Pull Request Test Coverage Report for Build 01867a47-a33a-4b0d-ad0a-34d0f11e6cd9

  • 0 of 9 (0.0%) changed or added relevant lines in 1 file are covered.
  • 46 unchanged lines in 10 files lost coverage.
  • Overall coverage increased (+0.03%) to 57.193%

Changes Missing Coverage Covered Lines Changed/Added Lines %
common/log/tag/tags.go 0 9 0.0%
Files with Coverage Reduction New Missed Lines %
service/history/queue/transfer_queue_processor_base.go 1 77.62%
common/membership/hashring.go 2 83.54%
common/task/parallelTaskProcessor.go 2 92.75%
common/task/weightedRoundRobinTaskScheduler.go 2 89.12%
service/history/execution/mutable_state_builder.go 2 68.76%
service/history/task/transfer_standby_task_executor.go 2 85.98%
common/persistence/nosql/nosqlplugin/cassandra/workflow.go 3 59.1%
service/matching/taskListManager.go 3 79.77%
common/persistence/nosql/nosqlplugin/cassandra/workflowParsingUtils.go 14 79.09%
service/history/execution/mutable_state_task_refresher.go 15 68.67%
Totals Coverage Status
Change from base Build 01867537-d02a-426c-8fc1-b9baf20eb662: 0.03%
Covered Lines: 85074
Relevant Lines: 148748

💛 - Coveralls

@bowenxia bowenxia changed the title add 3 tags to support CDNC-2946: Add logs for every manual access add 3 tags to support adding logs for every manual access Feb 22, 2023
@bowenxia bowenxia merged commit 471cf77 into cadence-workflow:master Feb 22, 2023
@bowenxia bowenxia deleted the CDNC-2946related_add_more_tags_for_logging branch February 22, 2023 23:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants